1750122 - [wpt-sync] Sync PR 32375 - Reland "AnonymousIframe: test BroadcastChannel""

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 32375 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/32375
Details from upstream follow.

Arthur Sonzogni <[e-mail]> wrote:

Reland "AnonymousIframe: test BroadcastChannel""

Original patch:
https://chromium-review.googlesource.com/c/chromium/src/+/3371612
Revert:
https://chromium-review.googlesource.com/c/chromium/src/+/3383915

The test was failing with the error:

FAIL broadcast-channel promise_test: Unhandled rejection with value: object "ReferenceError: newIframe is not defined"

This error has been introduced by the revert:
https://chromium-review.googlesource.com/c/chromium/src/+/3383079
because this is where the missing function was defined.

This patch reland the second patch and the missing function from
the other patch.

Diff from original patch: See Patchset 1/2 difference.

Bug: 1285331,1226469
Change-Id: I5c3190f00a6166f3711d481d0e6622f7b9b523e8
Fixed: 1285331
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3383340
Reviewed-by: Antonio Sartori \<[e-mail]>
Commit-Queue: Arthur Sonzogni \<[e-mail]>
Cr-Commit-Position: refs/heads/main@{#958548}

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=00d130a9734658042c4b5ac49f4a2c21a0b035c6

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 11 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 7 tests and 1 subtests

Status Summary

Firefox

OK : 1[Gecko-android-em-7.0-x86_64-lite-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-linux1804-64-tsan-qr-opt, Gecko-windows10-32-2004-qr-debug, Gecko-windows10-32-2004-qr-opt, Gecko-windows10-64-2004-qr-debug, Gecko-windows10-64-2004-qr-opt] 7[GitHub]
PASS : 8
FAIL : 2[Gecko-android-em-7.0-x86_64-lite-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-linux1804-64-tsan-qr-opt, Gecko-windows10-32-2004-qr-debug, Gecko-windows10-32-2004-qr-opt, Gecko-windows10-64-2004-qr-debug, Gecko-windows10-64-2004-qr-opt] 17[GitHub]
ERROR: 4

Chrome

OK : 7
PASS : 8
FAIL : 17

Safari

OK : 7
PASS : 9
FAIL : 16

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/html/cross-origin-embedder-policy/anonymous-iframe/anonymous-iframe-popup.tentative.https.window.html
Cross-origin popup from normal/anonymous iframes.: FAIL (Chrome: FAIL, Safari: FAIL)
Same-origin popup from normal/anonymous iframes.: FAIL (Chrome: FAIL, Safari: FAIL)
/html/cross-origin-embedder-policy/anonymous-iframe/broadcast-channel.tentative.window.html: ERROR [Gecko-android-em-7.0-x86_64-lite-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-linux1804-64-tsan-qr-opt, Gecko-windows10-32-2004-qr-debug, Gecko-windows10-32-2004-qr-opt, Gecko-windows10-64-2004-qr-debug, Gecko-windows10-64-2004-qr-opt], OK [GitHub] (Chrome: OK, Safari: OK)
broadcast-channel: FAIL (Chrome: FAIL, Safari: FAIL)
/html/cross-origin-embedder-policy/anonymous-iframe/cookie-store.tentative.https.window.html: ERROR [Gecko-android-em-7.0-x86_64-lite-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-linux1804-64-tsan-qr-opt, Gecko-windows10-32-2004-qr-debug, Gecko-windows10-32-2004-qr-opt, Gecko-windows10-64-2004-qr-debug, Gecko-windows10-64-2004-qr-opt], OK [GitHub] (Chrome: OK, Safari: OK)
/html/cross-origin-embedder-policy/anonymous-iframe/cookie.tentative.https.window.html: ERROR [Gecko-android-em-7.0-x86_64-lite-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-linux1804-64-tsan-qr-opt, Gecko-windows10-32-2004-qr-debug, Gecko-windows10-32-2004-qr-opt, Gecko-windows10-64-2004-qr-debug, Gecko-windows10-64-2004-qr-opt], OK [GitHub] (Chrome: OK, Safari: OK)
Anonymous same-origin iframe is loaded without credentials: FAIL (Chrome: FAIL, Safari: FAIL)
Anonymous cross-origin iframe is loaded without credentials: FAIL (Chrome: FAIL, Safari: FAIL)
same_origin anonymous iframe can't send same_origin credentials: FAIL (Chrome: FAIL, Safari: FAIL)
same_origin anonymous iframe can't send cross_origin credentials: FAIL (Chrome: FAIL, Safari: FAIL)
cross_origin anonymous iframe can't send cross_origin credentials: FAIL (Chrome: FAIL, Safari: FAIL)
cross_origin anonymous iframe can't send same_origin credentials: FAIL (Chrome: FAIL, Safari: FAIL)
same_origin anonymous iframe can't send same_origin credentials on child iframe: FAIL (Chrome: FAIL, Safari: FAIL)
same_origin anonymous iframe can't send cross_origin credentials on child iframe: FAIL (Chrome: FAIL, Safari: FAIL)
cross_origin anonymous iframe can't send cross_origin credentials on child iframe: FAIL (Chrome: FAIL, Safari: FAIL)
cross_origin anonymous iframe can't send same_origin credentials on child iframe: FAIL (Chrome: FAIL, Safari: FAIL)
/html/cross-origin-embedder-policy/anonymous-iframe/local-storage.tentative.https.window.html: ERROR [Gecko-android-em-7.0-x86_64-lite-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-linux1804-64-tsan-qr-opt, Gecko-windows10-32-2004-qr-debug, Gecko-windows10-32-2004-qr-opt, Gecko-windows10-64-2004-qr-debug, Gecko-windows10-64-2004-qr-opt], OK [GitHub] (Chrome: OK, Safari: OK)
same_origin anonymous iframe can't access the localStorage: FAIL (Chrome: FAIL, Safari: FAIL)
cross_origin anonymous iframe can't access the localStorage: FAIL (Chrome: FAIL, Safari: PASS)
/html/cross-origin-embedder-policy/anonymous-iframe/session-storage.tentative.https.window.html
same_origin anonymous iframe can't access the sessionStorage: FAIL (Chrome: FAIL, Safari: FAIL)
/html/cross-origin-embedder-policy/anonymous-iframe/web-lock.tentative.https.window.html
web-lock: FAIL (Chrome: FAIL, Safari: FAIL)

Comment 3

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/404f89e4972b
https://hg.mozilla.org/mozilla-central/rev/7603a731edde