1750189 - add code preffed off to delay hide of remote iframes during reconstruction

Status: ASSIGNED

(Core :: Web Painting, enhancement, P3)

Description

[Timothy Nikkel (:tnikkel)]

Add the code preffed off to fix bug 1737503. I plan to flip the pref in bug 1737503.

Comment 1

[Timothy Nikkel (:tnikkel)]

Attachment: Bug 1750189. Add test. r?miko,emilio,mstange,hiro

Comment 2

[Timothy Nikkel (:tnikkel)]

Attachment: Bug 1750189. Pass down a flag when calling BeginSwapDocShellsForDocument that tells us if we are destroy or swapping. r?mstange,emilio,miko

We need this for the next part because we need to know in DestroyDisplayItemDataForFrames if we are doing a frameloader swap or destroying the frame.

Depends on D135993

Comment 3

[Timothy Nikkel (:tnikkel)]

Attachment: Bug 1750189. Add code preffed off to delay hide of remote iframes during reconstruction. r?emilio,miko,mstange

Add the code preffed off to fix bug 1737503. I plan to flip the pref in bug 1737503.

Depends on D135994

Comment 4

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1750189 - Don't remove WebRenderUserData table on frame destruction. r=tnikkel

Comment 5

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1750189 - Add code preffed off to delay hide of remote iframes during reconstruction. r=tnikkel

Depends on D138731

Comment 6

[Emilio Cobos Álvarez (:emilio)]

https://treeherder.mozilla.org/jobs?repo=try&revision=0d0163541f778231b162c7e669e4904048992706 is the try run for the two patches above + the patch enabling it fwiw.

Comment 7

[Daniel Holbert [:dholbert]]

Attachment: testcase 3 (no interaction required): using 'scrollbar-width', repeatedly toggled via setInterval

Comment 8

[Daniel Holbert [:dholbert]]

Sorry, disregard comment 7; that attachment was meant for related bug 1764655, not this bug.

Comment 9

[BugBot [:suhaib / :marco/ :calixte]]

The following patches are waiting for review from an inactive reviewer:

ID	Title	Author	Reviewer Status
D138731	Bug 1750189 - Don't remove WebRenderUserData table on frame destruction. r=tnikkel	emilio	tnikkel: Inactive
D138732	Bug 1750189 - Add code preffed off to delay hide of remote iframes during reconstruction. r=tnikkel	emilio	tnikkel: Inactive

:emilio, could you please find another reviewer or abandon the patch if it is no longer relevant?

For more information, please visit auto_nag documentation.

Comment 10

[Timothy Nikkel (:tnikkel)]

Bad bot, I'm not inactive in any way.

Comment 11

[Timothy Nikkel (:tnikkel)]

Your bot is making mistakes.

Comment 12

[Marco Castelluccio [:marco]]

Sorry for the noise, there was a problem with a Bugzilla API that caused the bot to think more people were inactive than normal (bug 1789646).

Comment 13

[Timothy Nikkel (:tnikkel)]

This test passes now, so landing that.

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7964625c0d23
Add test. r=hiro

Comment 15

[amarc]

https://hg.mozilla.org/mozilla-central/rev/7964625c0d23