Theme with dark image wrongly assume I want a dark theme for everything
Categories
(Firefox :: Theme, defect)
Tracking
()
People
(Reporter: robert, Unassigned)
Details
Attachments
(2 files)
light.png
User Agent: Mozilla/5.0 (X11; Fedora; Linux x86_64; rv:96.0) Gecko/20100101 Firefox/96.0
Steps to reproduce:
Install a theme like Space Fantasy Redux by MFGookey (https://addons.mozilla.org/en-US/firefox/addon/space-fantasy-redux/?utm_source=addons.mozilla.org&utm_medium=referral&utm_content=search)
Actual results:
Firefox wrongly assume that I want a dark theme for everything, including Firefox chrome and web sites.
the browser.theme.toolbar-theme preference is changes to 0 after the theme installation, something that wasn't done in previous release.
Expected results:
Firefox should not try to be more intelligent than the user and should not change the dark theme related preferences only because an image is dark. I have been using a dark toolbar theme since image base themes were implemented and never wanted to have a dark theme applied to all content inside Firefox.
I having happy with the look of the attached image and now that is impossible to do without resorting to lockPrefs() hacks.
Maybe the theme selection UI should have a setting to override the "smart" code that think a dark background image means a dark theme for everything.
|
Reporter | |
Comment 1•3 years ago
|
||
I may add that changing the browser.theme.toolbar-theme preference after the theme installation is lost the next time a new window is opened.
|
||
Comment 2•3 years ago
|
||
The Bugbug bot thinks this bug should belong to the 'Firefox::Theme' component, and is moving the bug to that component. Please revert this change in case you think the bot is wrong.
|
||
Comment 3•3 years ago
|
||
|
|
Reporter | |
Comment 4•3 years ago
|
||
Thanks for a new hidden setting I guess. I still think this should be exposed on the UI.
Notice the new "workaround" doesn't work as before. The current selected tab is using light colors on top of a dark theme. On Firefox 95 this doesn't happened.
|
|
||
Comment 5•3 years ago
|
||
Ah. The light UI issue should already be tracked by bug 1749837.
|
|
Reporter | |
Comment 6•3 years ago
|
||
For the record on this closed bug, the workaround described on the link, (use layout.css.prefers-color-scheme.content-override) is only partial. The Firefox chrome is still in dark mode. It only override the content theme, not the chrome theme.
|
||
Comment 7•3 years ago
|
||
(In reply to Robert Marcano from comment #6)
For the record on this closed bug, the workaround described on the link, (use layout.css.prefers-color-scheme.content-override) is only partial. The Firefox chrome is still in dark mode. It only override the content theme, not the chrome theme.
Assuming by "Firefox chrome" you mean Menus/Buttons, this is addressed in the Bug that was linked above (DUPLICATE of bug 1749837)
Looks like the behaviour that these change depending on selected Theme always was a feature, however previous releases determined it based on wether background color set to a dark or light color. Now its based on text color of the Theme.
Description
•