1750205 - The text from the first "Firefox Suggest" modal is wrongly read by a screen reader software even if the second part of the modal is displayed

Status: VERIFIED FIXED

(Firefox :: Address Bar, defect, P1)

Description

[Marius Coman [:mcoman], Ecosystem QA]

[Affected versions]:

• Firefox Beta 97.0b3 - Build ID: 20220113185849

[Affected Platforms]:

• Windows 10 x64
• macOS 11.6
• Ubuntu 20.04 x64

[Prerequisites]:

• Have a Firefox build installed.
• Have the following user.js file copied to your PC.
• Have the update channel set to "Release".
• Have a screen reader software (E.G. NVDA) installed and enabled.

[Steps to reproduce]:

1. Create a new Firefox profile but do not open it.
2. Navigate to the profile folder and copy the user.js file from the prerequisites.
3. Open the browser using the previously created profile.
4. Focus the "Find out how" button and press the "Enter" key.
5. Observe the behavior.

[Expected result]:

• The text from the second part of the "Firefox Suggest" modal is successfully recognized and read by the screen reader.

[Actual result]:

• The text from the first part f the "Firefox Suggest" modal is read instead.

[Notes]:

• This issue is reproducible on all the experiment branches.
• This issue seems to be intermittent on macOS using the VoiceOver screen reader

Comment 1

[Drew Willcoxon :adw]

[Tracking Requested - why for this release]:
This is a blocker for the Firefox Suggest experiment in a 96 dot release.

Comment 2

[Drew Willcoxon :adw]

Attachment: Bug 1750205 - Properly handle a11y when the Firefox Suggest online opt-in modal changes panes/sections.

Updating aria-labelledby and aria-describedby seems to work. We aren't using
aria-live correctly I think, which is my fault since I suggested it. AFAICT
that should be used on an element whose subtree changes. That's not the case for
these h1 elements. It is the case for the body element, and I tried setting
aria-live=polite on it, but it ended up causing everything in the main section
to be read multiple times.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8a3d5c2f861b
Properly handle a11y when the Firefox Suggest online opt-in modal changes panes/sections. r=daisuke

Comment 4

[Drew Willcoxon :adw]

Comment on attachment 9259215 [details]
Bug 1750205 - Properly handle a11y when the Firefox Suggest online opt-in modal changes panes/sections.

Beta/Release Uplift Approval Request

• User impact if declined: This is a blocker for the Firefox Suggest experiment in a 96 dot release.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: Should be clear from the bug comments
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Very small patch that sets some DOM attributes to improve a11y in the Firefox Suggest online opt-in modal
• String changes made/needed:

Comment 5

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/8a3d5c2f861b

Comment 6

[Marius Coman [:mcoman], Ecosystem QA]

I have verified that this issue is no longer reproducible with the latest Firefox Nightly (98.0a1 Build ID - 20220116095124) installed on Windows 10 x64, macOS 11.6.2, and Ubuntu 20.04 x64. Now I can confirm that the title from the second page is successfully recognized by the screen reader software.

Also, during our verification, we observed that on macOS 11.6 the title from the first page is read twice by the VoiceOver screen reader, however, we logged a separate issue for this behavior (Bug 1750583).

Comment 7

[Ryan VanderMeulen [:RyanVM][PTO June 24-28]]

Comment on attachment 9259215 [details]
Bug 1750205 - Properly handle a11y when the Firefox Suggest online opt-in modal changes panes/sections.

Approved for 97.0b5.

Comment 8

[Ryan VanderMeulen [:RyanVM][PTO June 24-28]]

https://hg.mozilla.org/releases/mozilla-beta/rev/7c126747facd

Comment 9

[Dianna Smith [:diannaS] - on Leave, back on August 9th]

Comment on attachment 9259215 [details]
Bug 1750205 - Properly handle a11y when the Firefox Suggest online opt-in modal changes panes/sections.

Approved for 96.0.2

Comment 10

[Dianna Smith [:diannaS] - on Leave, back on August 9th]

https://hg.mozilla.org/releases/mozilla-release/rev/5a35d4c0fabb

Comment 11

[Cosmin Muntean [:cmuntean], Ecosystem QA]

I have verified this issue on the latest Beta 97.0b5 (Build ID: 20220118185733) and the latest build 96.0.2 (Build ID: 20220119040736) on Windows 10 x64, macOS 10.15.7 and Ubuntu 20.04 x64.

• The text from the second part of the "Firefox Suggest" modal is successfully recognized and read by the screen reader.