1750276 - <fieldset> not working box-shadow inset

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, defect)

Description

[devcustrom]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/97.0.4692.71 Safari/537.36

Steps to reproduce:

https://play.tailwindcss.com/aWFBA6nbQU

Actual results:

https://play.tailwindcss.com/aWFBA6nbQU

Expected results:

expect to see box-shadow inset in fieldset tag

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Core::DOM: Core & HTML' component, and is moving the bug to that component. Please revert this change in case you think the bot is wrong.

Comment 2

[Alice0775 White]

I can reproduce the issue in Firefpx91esr and 98.0a1 Windows10.
The issue go away if WebRender is disabled in 91esr.

Comment 3

[Alice0775 White]

Regression window:
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=a21099ce055f983cd642732d49148d3bfaa2d686&tochange=6d0f18e0387602d534a03c2cae10cf6b814ea9fd

Regressed by:
d868d37155547fdfb02e68d477ae55e32f924ea4 Glenn Watson — servo: Merge #18926 - Update WR (box shadows, subpixel + alpha text) (from glennw:update-wr-bs); r=jdm
or
1347bb0b084bf245ff9315d07e3646547aa0c8e0 Emilio Cobos Álvarez — servo: Merge #18937 - style: Use a proper flattened tree iterator if we're under a shadow tree (from emilio:shadow-proper-flattened-tree); r=heycam

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

:alice0775, since this bug is a regression, could you fill (if possible) the regressed_by field?
For more information, please visit auto_nag documentation.

Comment 5

[Alice0775 White]

(In reply to Release mgmt bot [:marco/ :calixte] from comment #4)

:alice0775, since this bug is a regression, could you fill (if possible) the regressed_by field?
For more information, please visit auto_nag documentation.

See comment#3.

Comment 6

[Sotaro Ikeda [:sotaro]]

:gw, can you comment to this bug?

Comment 7

[Glenn Watson [:gw]]

I can reproduce the bug locally with the provided data URL.

I saved a WR capture file and inspected the scene - there doesn't appear to be any box-shadow primitive in the content display list at all (just a couple of background rectangles and the groove border).

Perhaps the Gecko DL building code or DL->WR converting code is ignoring the box-shadow on a fieldset?

Comment 8

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1750276 - Fix inset box shadow painting of fieldsets. r=miko,gw

Fieldsets have rather weird background and border painting rules, so we
paint inset box shadows as part of the nsFieldSetBorder display item.

However there was no equivalent to this call in the WebRender
implementation:

https://searchfox.org/mozilla-central/rev/d4b9c457db637fde655592d9e2048939b7ab2854/layout/forms/nsFieldSetFrame.cpp#296

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2c37aa3ea90b
Fix inset box shadow painting of fieldsets. r=miko

Comment 10

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/32474 for changes under testing/web-platform/tests

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cf8829a3353a
Annotate a test that now passes.

Comment 12

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/2c37aa3ea90b
https://hg.mozilla.org/mozilla-central/rev/cf8829a3353a

Comment 13

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot

Comment 14

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:emilio, is this bug important enough to require an uplift?
If not please set status_beta to wontfix.

For more information, please visit auto_nag documentation.

Comment 15

[Emilio Cobos Álvarez (:emilio)]

Pretty old regression so probably can ride the trains.