Closed Bug 1750298 Opened 2 years ago Closed 2 years ago

Remove `forAuthorCode` workaround for Fetch and use ReadableStreamDefaultReadResult

Categories

(Core :: DOM: Streams, task, P3)

Product:
Core
Component:
DOM: Streams
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
100 Branch
Tracking Flags:
Tracking Status
firefox100 --- fixed

People

(Reporter: mgaudet, Assigned: evilpie)

References

(Depends on 1 open bug, Blocks 1 open bug)

Details

Attachments

(1 file)

Bug 1750298 - Use custom ReadRequest for FetchStreamReader. r?smaug!,mgaudet
48 bytes, text/x-phabricator-request
Details | Review

In Bug 1734873 we ended up adding the forAuthorCode system to avoid getting trapped by Object.prototype.then

Evilpie kindly pointed out that a more architecturally sound answer would be to instead use a separate type of ReadRequest for fetch code; which makes perfect sense in hindsight and should definitely be something we do.

This is changing some rather complex code in the FetchStreamReader so I would like to avoid potentially spoiling the initial landing of DOM streams by delaying this for a few days.

Summary: Remove `forAuthorCode` workaround for Fetch → Remove `forAuthorCode` workaround for Fetch and use ReadableStreamDefaultReadResult
Blocks: 1730584
Assignee: nobody → evilpies
Attachment #9261971 - Attachment description: WIP: Bug 1750298 - Use custom ReadRequest for FetchStreamReader → Bug 1750298 - Use custom ReadRequest for FetchStreamReader
See Also: → 1752880
Attachment #9261971 - Attachment description: Bug 1750298 - Use custom ReadRequest for FetchStreamReader → WIP: Bug 1750298 - Use custom ReadRequest for FetchStreamReader
Attachment #9261971 - Attachment description: WIP: Bug 1750298 - Use custom ReadRequest for FetchStreamReader → Bug 1750298 - Use custom ReadRequest for FetchStreamReader. r?smaug!,mgaudet
No longer blocks: 1730584
Pushed by evilpies@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/4ec8f7211b07
Use custom ReadRequest for FetchStreamReader. r=smaug

https://hg.mozilla.org/mozilla-central/rev/4ec8f7211b07

Status: NEW → RESOLVED
Closed: 2 years ago
status-firefox100: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 100 Branch
Regressions: 1760419
Depends on: 1760555
Regressions: 1760555
Regressions: 1761829
Depends on: 1761829
No longer regressions: 1761829
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: