Closed
Bug 1750501
Opened 3 years ago
Closed 3 years ago
Verify if all error conditions of DisentanglePort in MessagePortParent::RecvDisentangle merit an IPC_FAIL
Categories
(Core :: DOM: postMessage, task)
Core
DOM: postMessage
Tracking
()
RESOLVED
WORKSFORME
People
(Reporter: jstutte, Unassigned)
Details
MessagePortParent::RecvDisentangle returns IPC_FAIL in case that mService->DisentanglePort fails.
Given the general rule of considering IPC_FAIL fatal for the caller (see bug 1748920) we should check, if any/all of the failure conditions of PostMessages really merit such a response.
|
||
Updated•3 years ago
|
Component: IPC → DOM: postMessage
|
||
Comment 1•3 years ago
|
||
Looks like all of the IPC_FAIL cases are valid in this case. They are basically runtime assertions.
And MessagePortService::DisentanglePort may return false in case of OOM. If that happens, it is ok to crash child process, and rather child than the parent process.
In theory information about OOM could be passed back to the child process, but there isn't really anything it could do about it. MessagePort handling would be just broken.
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → WORKSFORME
You need to log in
before you can comment on or make changes to this bug.
Description
•