Closed Bug 1750602 Opened 4 years ago Closed 3 years ago

Edges on fullscreen videos with two monitors

Categories

(Core :: Widget: Win32, defect, P2)

Firefox 96
Unspecified
Windows
defect

Tracking

()

RESOLVED DUPLICATE of bug 1763981

People

(Reporter: blues.krb, Unassigned)

References

Details

(Keywords: multi-monitors, Whiteboard: [win:multimonitors][win:fullscreen])

Attachments

(5 files)

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:96.0) Gecko/20100101 Firefox/96.0

Steps to reproduce:

Loaded a video site such as youtube, twitch, netflix etc.
Selected the video
Hit fullscreen for the video.

Note: Firefox was maximized and minimized in testing to eliminate that as an issue.

Actual results:

Upon making a video fullscreen the video wont go enitrely fullscreen as there will be an edge on the left and top of the video showing my desktop wallpaper.

Been an issue for months and have done multiple fresh installs of windows both on my laptop and desktop the issue happens on both.

Expected results:

Video goes "completely" fullscreen with no edges

The Bugbug bot thinks this bug should belong to the 'Core::DOM: Core & HTML' component, and is moving the bug to that component. Please revert this change in case you think the bot is wrong.

Component: Untriaged → DOM: Core & HTML
Product: Firefox → Core
See Also: → 1750603
Severity: -- → S2

Edgar, could you look at this (and bug 1750603 which Alice found and sounds very similar)? Thanks.

Flags: needinfo?(echen)

I could not reproduce the issue on Mac, probably a Windows-specific issue?
Hi Asidius, could you try Nightly or clean profile to see if you could still reproduce this? Thanks!

Flags: needinfo?(echen) → needinfo?(blues.krb)

Hi Daniel, I am not able to access the Windows machine at the moment.
Could someone from QA team help to reproduce this on Windows? Thanks!

Flags: needinfo?(daniel.bodea)

can confirm having the exact same issue (see above mentioned duplicate), having this issue already for about 2 months i think. Using windows 11 myself.

Status: UNCONFIRMED → NEW
Ever confirmed: true
OS: Unspecified → Windows

I marked this S2 because it sounds like people can still mostly watch videos on full screen just fine, but it is still a fairly unfortunate regression to have. Maybe there's some kind of rounding error in some calculation?

QA Whiteboard: [qa-regression-triage]

I cannot reproduce it nightly 98.0a1, Win 11 when watching videos on youtube or prime video.

Is there any information i can provide that would help you to recreate the issue? Because i have it fairly considtently. It isn't a very rare issue for me

(In reply to mi_thom from comment #9)

Is there any information i can provide that would help you to recreate the issue? Because i have it fairly considtently. It isn't a very rare issue for me

Hi thanks for asking! It'd be very helpful to figure out where this regression came from. https://mozilla.github.io/mozregression/ - this is a tool that can help you do bisection.

Flags: needinfo?(mi_thom)

I tried to reproduce the issue on Win10x64 using build 98.0a1(20220117214941) but with no luck. Youtube and twitch videos full screen loads without issues. I suppose this might be Win11 issue related. Leaving the qe+ flag in order to be reproduced on Win11. Thank you.

I was unable to reproduce the issue with the exact steps from description on Win 11x64 using Fx Release 96.0, 96.0.1, Nightly 96.0a1 and 98.0a1. Youtube,Netflix and twitch videos full screen loads without issues.
Do you know the cause that reproduces the issue? Do you have any add-ons installed? Which protocol do you use?
Can you please try to reproduce this issue on safe mode: https://support.mozilla.org/en-US/kb/diagnose-firefox-issues-using-troubleshoot-mode

using the troubleshoot-mode, i did not manage to reproduce the issue either.
The cause must be the theme or one of my addons indeed. I will one by one disble them and see if i can detect which one causes it.

This appears to not be a regression, then. However, we're expecting some information to reconfirm it.
Thank you, mi_thom!

QA Whiteboard: [qa-regression-triage]
Flags: needinfo?(daniel.bodea)

Closing this per comment 13.

Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → WORKSFORME
See Also: → 1759491
Flags: needinfo?(blues.krb)
Status: RESOLVED → REOPENED
Resolution: WORKSFORME → ---

This has NOT been resolved. Still experience the fullscreen video bug on refresh installs across 5 different devices.

Further more to this there is a another fullscreen bug where the firefox window will experience the same border bug when going fullscreen with F11, visible in the below image.

https://imgur.com/a/ixNBvot

Both bugs STILL present in v101.0.1. Anything being done about it? Or should i just not use firefox anymore since nothing gets fixed?

@Asidius this might be my fault, one time i tried to help them by doing a regression analysis without any addons, and i couldn't get the bug to appear. Since then they decided that it is caused by some addon. I am also getting this bug on other pc's than my main, so it clearly is not due to addons, but i feel like they are not changing their mind

@Asidius, there is no progress mainly because we could not reproduce on our side, so we don't know what goes wrong. :(
Per comment 13 and bug 1759491 comment 4, this seems not happen in troubleshoot-mode. Could you also help to try troubleshoot-mode on your side? If it you also could not reproduce in troubleshoot-mode, then we could narrow down the issue a bit.

And per bug 1759491 comment 4, it seems disabling all extensions and reverting the theme doesn't help, it would be helpful if you could try whether turning off hardware acceleration helps, see https://support.mozilla.org/en-US/kb/troubleshoot-extensions-themes-to-fix-problems#w_turn-off-hardware-acceleration.

Thanks!

Flags: needinfo?(blues.krb)

(In reply to Edgar Chen [:edgar] from comment #19)

@Asidius, there is no progress mainly because we could not reproduce on our side, so we don't know what goes wrong. :(
Per comment 13 and bug 1759491 comment 4, this seems not happen in troubleshoot-mode. Could you also help to try troubleshoot-mode on your side? If it you also could not reproduce in troubleshoot-mode, then we could narrow down the issue a bit.

And per bug 1759491 comment 4, it seems disabling all extensions and reverting the theme doesn't help, it would be helpful if you could try whether turning off hardware acceleration helps, see https://support.mozilla.org/en-US/kb/troubleshoot-extensions-themes-to-fix-problems#w_turn-off-hardware-acceleration.

Thanks!

Thanks for this.

So I tested troubleshoot mode and the issue did not occur.

I proceeded to test with all addons removed as well as try each individual theme and the is still remained.

I run the browser with hardware acceleration off all the time. I turned it on and still had the same issue.

Flags: needinfo?(blues.krb)

I have the same issue and I tried to figure out why it happens. I tried going fullscreen on a video when the Firefox browser window is not maximized, and the problem did not occur. I think the problem might be related to the multi-monitor setup, maybe there is some weird interaction where the actual desktop area is misaligned the first time and then fixes itself when going fullscreen again? I can confirm after playing around a bit more that if I only connect my main monitor, the problem does not occur even if the Firefox window is maximized, so it must be related to multiple monitors being connected.

Now that you mention it, i cant remember having this bug without multiple monitors inderd

Flags: needinfo?(mi_thom)

Hi Bodea Danie,
We seem to get new information in comment 21. Would you please try to reproduce this again, with the setup with multiple monitors? Thanks!

Flags: needinfo?(daniel.bodea)

This seems like a bug that could not be missed by QA. It must be an uncommon system set-up that @mi_thom or @Asidius has because this issue has NOT been encountered by the desktop team while validating the latest builds for a long time. Furthermore, I have tested it with 3 different set-ups and different aspect ratios, sizes, quality of render and scaling.

@mi_thom and/or @Asidius:

  1. Can you say what would be different or special about your set-ups?
  2. What monitors are you using?
  3. What type of video connection do they have?
  4. Uncommon or different aspect ratio between them?
  5. What resolutions do they have?
  6. It is still reproducing as it always has been? On what version?

Thanks!

Flags: needinfo?(mi_thom)
Flags: needinfo?(daniel.bodea)
Flags: needinfo?(blues.krb)

(In reply to Bodea Daniel [:danibodea] from comment #24)

This seems like a bug that could not be missed by QA. It must be an uncommon system set-up that @mi_thom or @Asidius has because this issue has NOT been encountered by the desktop team while validating the latest builds for a long time. Furthermore, I have tested it with 3 different set-ups and different aspect ratios, sizes, quality of render and scaling.

@mi_thom and/or @Asidius:

  1. Can you say what would be different or special about your set-ups?
  2. What monitors are you using?
  3. What type of video connection do they have?
  4. Uncommon or different aspect ratio between them?
  5. What resolutions do they have?
  6. It is still reproducing as it always has been? On what version?

Thanks!

I can't recall anything special about my set up.
My specs are: Intel 8700k, ASUS Z370 TUF gaming plus mobo, RAM 16GB Crucial Ballistix, RTX 3070 (experienced it on my gtx1070 too)

Main Monitor 1 : LG UltraGear 24GN600 previously AOC C24G1 (Issue occurred on both)
Monitor 2: Basic Dell 24" FHD

Monitor 1: Uses Displayport
Monitor 2: Uses HDMI

16:9 is the aspect ratio on both

Both run on 1920x1080

Yes, the issue still occurs. Using version 104.0 (which is shown as the latest version when checking for updates)

Flags: needinfo?(blues.krb)

NI for taking another look at for comment 25

Flags: needinfo?(daniel.bodea)

Same issue. I also have two monitors, the first being HP X24ih (1920x1080, 144hz, DisplayPort) and the second one being Samsung SyncMaster SA200 (1440x900, 75hz, HDMI). My GPU is GeForce RTX 3070 Ti. Still occurs on 105.0b9 Developer Edition in normal mode, but does not occur in Troubleshoot mode. However, if I disable hardware acceleration and disable all addons in normal mode, the issue does not go away.

I have a very similar system to yours that I can test on and it does not reproduce:
AMD FX(tm)-6350 Six-Core Processor 3.90 GHz, 12GB RAM, ASUS M5A97 R2 mobo, GTX1050 GPU;
Monitor 1: LG 34GL750 21:9 2560x1080 144Hz G-Sync with DisplayPort
Monitor 2: Dell P2419H 16:9 1920x1080 60Hz with HDMI

I've also attempted reproduction on another W10 system
AMD FX(tm)-8320 Eight-Core Processor, 16GBGB RAM
Monitor 1: Dell P2419H 16:9 1920x1080 60Hz with HDMI
Monitor 2: Dell P2419H 16:9 1920x1080 60Hz with DVI

From this information, we can exclude the causes: connectivity, resolution, refresh rate, aspect ratio.

The similarities between the system of Asidius system and Resident007 systems different than mine are the fact that they use a bit stronger NVidia GPUs and probably the intel vs AMD architecture.

I suspect this might be related to GPU drivers used, or, in any case, information that could be compared using information from the about:support page.

Asidius, mi_thom, demirci.sinan96, Resident007: Would you be so kind as to provide us with the information displayed in the about:support page in Firefox?
(Open about:support in a Firefox that reproduces the issue, click the "Copy raw data to clipboard" button and paste it in a text file, then attache it to the bug.)

Thank you so much for your contributions!

Flags: needinfo?(demirci.sinan96)
Flags: needinfo?(daniel.bodea)
Flags: needinfo?(blues.krb)
Flags: needinfo?(andreyvdovichenko)

@Hsin-Yi Tsai: Do you have any clue why the issue would not reproduce in Safe Mode, but it would if disabling hardware acceleration and disabling all addons in normal mode, as stated in comment 27 by Resident007?
Could you try to obtain this information from someone in this area of expertise?

Flags: needinfo?(htsai)
(In reply to Bodea Daniel [:danibodea] from comment #28) > I have a very similar system to yours that I can test on and it does not reproduce: > AMD FX(tm)-6350 Six-Core Processor 3.90 GHz, 12GB RAM, ASUS M5A97 R2 mobo, GTX1050 GPU; > Monitor 1: LG 34GL750 21:9 2560x1080 144Hz G-Sync with DisplayPort > Monitor 2: Dell P2419H 16:9 1920x1080 60Hz with HDMI > > I've also attempted reproduction on another W10 system > AMD FX(tm)-8320 Eight-Core Processor, 16GBGB RAM > Monitor 1: Dell P2419H 16:9 1920x1080 60Hz with HDMI > Monitor 2: Dell P2419H 16:9 1920x1080 60Hz with DVI > > From this information, we can exclude the causes: connectivity, resolution, refresh rate, aspect ratio. > > The similarities between the system of Asidius system and Resident007 systems different than mine are the fact that they use a bit stronger NVidia GPUs and probably the intel vs AMD architecture. > > I suspect this might be related to GPU drivers used, or, in any case, information that could be compared using information from the about:support page. > > > > Asidius, mi_thom, demirci.sinan96, Resident007: Would you be so kind as to provide us with the information displayed in the about:support page in Firefox? > (Open about:support in a Firefox that reproduces the issue, click the "Copy raw data to clipboard" button and paste it in a text file, then attache it to the bug.) > > Thank you so much for your contributions! Here you go:

(In reply to Bodea Daniel [:danibodea] from comment #28)

I have a very similar system to yours that I can test on and it does not reproduce:
AMD FX(tm)-6350 Six-Core Processor 3.90 GHz, 12GB RAM, ASUS M5A97 R2 mobo, GTX1050 GPU;
Monitor 1: LG 34GL750 21:9 2560x1080 144Hz G-Sync with DisplayPort
Monitor 2: Dell P2419H 16:9 1920x1080 60Hz with HDMI

I've also attempted reproduction on another W10 system
AMD FX(tm)-8320 Eight-Core Processor, 16GBGB RAM
Monitor 1: Dell P2419H 16:9 1920x1080 60Hz with HDMI
Monitor 2: Dell P2419H 16:9 1920x1080 60Hz with DVI

From this information, we can exclude the causes: connectivity, resolution, refresh rate, aspect ratio.

The similarities between the system of Asidius system and Resident007 systems different than mine are the fact that they use a bit stronger NVidia GPUs and probably the intel vs AMD architecture.

I suspect this might be related to GPU drivers used, or, in any case, information that could be compared using information from the about:support page.

Asidius, mi_thom, demirci.sinan96, Resident007: Would you be so kind as to provide us with the information displayed in the about:support page in Firefox?
(Open about:support in a Firefox that reproduces the issue, click the "Copy raw data to clipboard" button and paste it in a text file, then attache it to the bug.)

Thank you so much for your contributions!

Sure, attached it to the bug.

Flags: needinfo?(andreyvdovichenko)

Data attached

Flags: needinfo?(blues.krb)
Attached file about_support.txt
Flags: needinfo?(mi_thom)

i don't know what the settings mean of course, but i did notice that under graphics -> totalNumScreens for both me and Asidius it says 1, while both of us have said to have a 2 screen setup. Probably this setting means something else, but i thought it was worth mentioning

attached the log file

Flags: needinfo?(demirci.sinan96)

Due to that the issue happens with multi monitors and comment 34 points out some inconsistency in the screen numbers in the config v.s. the actual number, I think it may help better to gather input from the widget team.

Severity: S2 → --
Component: DOM: Core & HTML → Widget: Win32
Flags: needinfo?(htsai)
Keywords: multi-monitors
Summary: Edges on fullscreen videos → Edges on fullscreen videos with two monitors
Severity: -- → S2
Priority: -- → P2
Whiteboard: [win:multimonitors][win:fullscreen]

Ugh. Yes, this is bug 1763981; and we've been having the same difficulty reproducing the issue despite it being trivially reproducible for users.

One user there has reported being able to toggle repro/no-repro solely by changing the refresh rate, so I'm a lot more hesitant to rule it out than comment #28. It's plausible that it's a timing issue, though, and that changing the refresh rate is enough to force it into existence on that system.

I should be able to test on a 144Hz monitor soon; hopefully that'll be enough that I can reproduce it.

Merging as duplicate -- though I'm also CCing myself on this bug, so feel free to reply here if it's relevant.


(In reply to mi_thom from comment #34)

i don't know what the settings mean of course, but i did notice that under graphics -> totalNumScreens for both me and Asidius it says 1, while both of us have said to have a 2 screen setup. Probably this setting means something else, but i thought it was worth mentioning

I don't see a totalNumScreens value? There's totalNumWindows, but I believe that only tracks the number of Firefox windows you have open.

Status: REOPENED → RESOLVED
Closed: 4 years ago3 years ago
Resolution: --- → DUPLICATE

that last comment made me remember i do have 1 144Hz screen. Worth noticing is that the bug happens on my old screen and not on the 144Hz screen. But as the 144Hz is my main screen i cna indeed see this having an influence.
For my work setup, i do not know the refresh rates of the screensas it is a laptop screen and 2 separate ones.

on another note, you are completely right about the totalNumWindows comment, i think i misread. appologies

You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: