1750670 - Better support orientation.lock('natural')

Status: RESOLVED FIXED

(GeckoView :: General, defect, P2)

Description

[Makoto Kato [:m_kato]]

natural is defined as (from https://w3c.github.io/screen-orientation/#dfn-natural)

Natural is an orientation that refers to either portrait-primary or landscape-primary depending on the device's usual orientation. This orientation is usually provided by the underlying operating system.

Actually, GeckoView maps it as (https://searchfox.org/mozilla-central/rev/afbff3f3ae087181d9988fe19e09cc15927fb7ff/mobile/android/geckoview/src/main/java/org/mozilla/geckoview/GeckoRuntime.java#874-875
)

    } else if (geckoOrientation == ScreenOrientation.DEFAULT.value) {
      return ActivityInfo.SCREEN_ORIENTATION_UNSPECIFIED;

SCREEN_ORIENTATION_UNSPECIFIED seems to mean unlock, so it isn't correct. So we should use better orientation type in GeckoView implement. or set landscape/portrait on natural in DOM side.

Also, Chromium considers this well.

Comment 1

[Chris Peterson [:cpeterson]]

Assigning this bug to Makoto. He will decide whether we need to prioritize it for 2022 H2.

Comment 2

[Makoto Kato [:m_kato]]

Attachment: Bug 1750670 - Better support orientation.lock('natural'). r=#geckoview-reviewers

natural is defined as (from https://w3c.github.io/screen-orientation/#dfn-natural)

A computer monitor are commonly naturally landscape-primary, while a mobile
phones are commonly naturally portrait-primary.

But GeckoView sets SCREEN_ORIENTATION_UNSPECIFIED that is unlock orientation.

Like Blink, we should set landscape-primary or portrait-primary (depends on
current monitor).

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/80a977fdc7f4
Better support orientation.lock('natural'). r=geckoview-reviewers,calu

Comment 4

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/80a977fdc7f4