1750702 - can't zoom in toolbox moved to tab opened with window.open

Status: NEW

(DevTools :: Framework, defect, P3)

Description

[Nicolas Chevobbe [:nchevobbe]]

Steps to reproduce

1. With devtools.popups.debug set to true, open devtools on this tab
2. In the console, execute window.open("about:blank")
3. This should open a new tab with devtools opened
4. Make sure the focus is on the toolbox (e.g. clicking in the console input)
5. Hit Ctrl (Cmd on OSX) and + to zoom in (or use Ctrl/Cmd + mousewheel)

Expected results

The toolbox gets zoomed

Actual results

The content page is zoomed (see the zoom indicator in the url bar), even if the focus is on the toolbox

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1569859

Comment 2

[Julian Descottes [:jdescottes]]

Nicolas checked that opening a tab with window open and then opening DevTools doesn't reproduce the issue. So this is really related to moving the toolbox.

Comment 3

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Alex, could this be related to the "magical" swapFrameLoaders API?
(used in https://phabricator.services.mozilla.com/D131802)

Honza

Comment 4

[Alexandre Poirot [:ochameau]]

I don't think it relaces to swapFrameLoader. If so, it would most likely also fail when moving between window and bottom hosts, whereas it does not.

It might relate to this code:
https://searchfox.org/mozilla-central/rev/e66593593f3b356901011ea0fcdf9979728e9ae8/devtools/client/framework/toolbox.js#1235-1238

    // Add zoom-related shortcuts.
    if (!this._hostOptions || this._hostOptions.zoom === true) {
      ZoomKeys.register(this.win, this.shortcuts);
    }

Or this other one:
https://searchfox.org/mozilla-central/rev/e66593593f3b356901011ea0fcdf9979728e9ae8/devtools/client/shared/zoom-keys.js#28

  const bc = BrowsingContext.getFromWindow(window);

Or yet this other one:
https://searchfox.org/mozilla-central/rev/e66593593f3b356901011ea0fcdf9979728e9ae8/devtools/client/framework/toolbox-host-manager.js#135-155
(this last one would rather cause glicthes rather than total miss of the feature)

Comment 5

[Jan Honza Odvarko [:Honza] (always need-info? me)]

This report represents an issue with new feature that is still being hidden behind a pref, so not "real" regression.