Open Bug 1750896 Opened 3 years ago Updated 3 years ago

RuntimeSettings.updatePrefs is annotated @AnyThread but is not thread safe

Categories

(GeckoView :: General, defect, P2)

Product:
GeckoView
Component:
General
Platform:
Unspecified
All
Type:
defect

Tracking

(Not tracked)

People

(Reporter: mcomella, Unassigned)

References

(Depends on 1 open bug)

Details

RuntimeSettings.updatePrefs is annotated @AnyThread but mPrefs is an ArrayList, a non-thread safe data structure.

Furthermore, RuntimeSettings.Pref is also not thread safe. mPrefs is an ArrayList<Pref> and updatePrefs access mutable fields from Pref from @AnyThread without synchronization.

Severity: -- → S3
Priority: -- → P2

I have a patch making RuntimeSettings.Pref thread safe in bug 1751306. If we decide to fix the RuntimeSettings.updatePrefs concurrency bug by confining access to a single thread, that patch may not be needed.

You need to log in before you can comment on or make changes to this bug.