Closed Bug 1750974 Opened 2 years ago Closed 2 years ago

Extend ESLint's import-globals-from function to support absolute directories

Categories

(Developer Infrastructure :: Lint and Formatting, task, P3)

Product:
Developer Infrastructure
Component:
Lint and Formatting
Type:
task

Tracking

(firefox98 fixed)

Status:
RESOLVED FIXED
Milestone:
98 Branch
Tracking Flags:
Tracking Status
firefox98 --- fixed

People

(Reporter: standard8, Assigned: standard8)

Details

Attachments

(1 file)

Bug 1750974 - Extend our ESLint import-globals-from function to support absolute directories.
48 bytes, text/x-phabricator-request
Details | Review

Currently uses of import-globals-from require that the path is relative. This means that in some cases we have to use multiple ../ to get back to the top level directory of the repository.

We can change this so that import-globals-from takes absolute paths from the top of the source tree.

Attachment #9259728 - Attachment description: Bug 1750974 - Extend our ESLint import-globals-from function to support absolute directories. → WIP: Bug 1750974 - Extend our ESLint import-globals-from function to support absolute directories.
Attachment #9259728 - Attachment description: WIP: Bug 1750974 - Extend our ESLint import-globals-from function to support absolute directories. → Bug 1750974 - Extend our ESLint import-globals-from function to support absolute directories.
Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c44b57b434b7
Extend our ESLint import-globals-from function to support absolute directories. r=Gijs,mossop

https://hg.mozilla.org/mozilla-central/rev/c44b57b434b7

Status: NEW → RESOLVED
Closed: 2 years ago
status-firefox98: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 98 Branch
Product: Firefox Build System → Developer Infrastructure
You need to log in before you can comment on or make changes to this bug.