1751036 - Crash [@ mozilla::ProfilerChild::ProcessPendingUpdate()] when restarting for an update

Status: NEW

(Core :: Gecko Profiler, defect, P2)

Description

[Florian Quèze [:florian]]

My Nightly offered to restart for an update. I accepted. Things seemed to work fine but after the restart an OS X crash reporting dialog popped up.

Given the stacks in the report, I suspect I forgot to capture whatever I was profiling before I accepted the restart.

Here's the report:

Crashed Thread:        1  SamplerThread

Exception Type:        EXC_BAD_ACCESS (SIGSEGV)
Exception Codes:       KERN_INVALID_ADDRESS at 0x0000000000000000
Exception Note:        EXC_CORPSE_NOTIFY

Termination Signal:    Segmentation fault: 11
Termination Reason:    Namespace SIGNAL, Code 0xb
Terminating Process:   exc handler [80051]

VM Regions Near 0:
--> 
    __TEXT                 000000010d0ed000-000000010d0f0000 [   12K] r-x/r-x SM=COW  /Applications/Firefox Nightly.app/Contents/MacOS/firefox

Thread 0:: MainThread  Dispatch queue: com.apple.main-thread
0   XUL                           	0x00000001175369c1 mozilla::UniquePtr<std::__1::vector<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, std::__1::allocator<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > > >, mozilla::DefaultDelete<std::__1::vector<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, std::__1::allocator<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > > > > >::~UniquePtr() + 1
1   libsystem_c.dylib             	0x00007fff6945013c __cxa_finalize_ranges + 319
2   libsystem_c.dylib             	0x00007fff69450412 exit + 55
3   XUL                           	0x00000001184e682b ApplyUpdate(nsIFile*, nsIFile*, nsIFile*, int, char**, bool, bool, int*) + 2331
4   XUL                           	0x00000001184e5da6 ProcessUpdates(nsIFile*, nsIFile*, nsIFile*, int, char**, char const*, bool, int*) + 550
5   XUL                           	0x0000000114b76572 XREMain::XRE_mainStartup(bool*) + 1730
6   XUL                           	0x00000001184e3ae9 XREMain::XRE_main(int, char**, mozilla::BootstrapConfig const&) + 745
7   XUL                           	0x00000001184e3ec7 XRE_main(int, char**, mozilla::BootstrapConfig const&) + 71
8   org.mozilla.nightly           	0x000000010d0ef4d4 main + 564
9   libdyld.dylib                 	0x00007fff693a6cc9 start + 1

Thread 1 Crashed:: SamplerThread
0   libmozglue.dylib              	0x000000010d133edc mozilla::detail::MutexImpl::lock() + 60
1   XUL                           	0x000000011836fcca mozilla::ProfilerChild::ProcessPendingUpdate() + 26
2   XUL                           	0x0000000118346388 SamplerThread::Run() + 2088
3   XUL                           	0x0000000118348e39 ThreadEntry(void*) + 9
4   libsystem_pthread.dylib       	0x00007fff695ab109 _pthread_start + 148
5   libsystem_pthread.dylib       	0x00007fff695a6b8b thread_start + 15

Thread 2:
0   libsystem_pthread.dylib       	0x00007fff695a6b68 start_wqthread + 0

Thread 3:
0   libsystem_pthread.dylib       	0x00007fff695a6b68 start_wqthread + 0

Thread 4:: Breakpad ExceptionHandler
0   libsystem_kernel.dylib        	0x00007fff694e7dfa mach_msg_trap + 10
1   libsystem_kernel.dylib        	0x00007fff694e8170 mach_msg + 60
2   XUL                           	0x0000000114b6b57b google_breakpad::ExceptionHandler::WaitForMessage(void*) + 107
3   libsystem_pthread.dylib       	0x00007fff695ab109 _pthread_start + 148
4   libsystem_pthread.dylib       	0x00007fff695a6b8b thread_start + 15

Thread 5:
0   libsystem_pthread.dylib       	0x00007fff695a6b68 start_wqthread + 0

Thread 6:
0   libsystem_pthread.dylib       	0x00007fff695a6b68 start_wqthread + 0

Thread 1 crashed with X86 Thread State (64-bit):
  rax: 0x000000010d192f48  rbx: 0x0000000000000016  rcx: 0x000000010d195348  rdx: 0x0000000000000000
  rdi: 0x00007fff8faf6ca8  rsi: 0x00000000000120a8  rbp: 0x000070000b5ac790  rsp: 0x000070000b5ac780
   r8: 0x00000000000130a8   r9: 0x0000000000000000  r10: 0x00007fff8faf6cc8  r11: 0x00007fff8faf6cc0
  r12: 0x0000000000000003  r13: 0x0000000000000000  r14: 0x000000010d36c000  r15: 0x00000000000f4240
  rip: 0x000000010d133edc  rfl: 0x0000000000010202  cr2: 0x0000000000000000
  
Logical CPU:     6
Error Code:      0x00000006 (no mapping for user data write)
Trap Number:     14

Comment 1

[Markus Stange [:mstange]]

The mutex was probably destroyed on the main thread, and locking a destroyed mutex is bad.