1751041 - Compute the process creation timestamp during startup

Status: RESOLVED FIXED

(Core :: mozglue, task)

Description

[Gabriele Svelto [:gsvelto]]

We currently generate the process creation timestamp lazily, whenever someone requests it. This is causing me issues with the GC hazards detector in bug 1678152 because it thinks that we might be allocating memory while creating JS objects that require the process creation timestamp. I suppose we could just generate the timestamp greedily at startup to solve this particular problem. Every process we have requests it more than once so this wouldn't change anything in practice, we'd just move the computation sometimes earlier during process startup.

Comment 1

[Gabriele Svelto [:gsvelto]]

Attachment: Bug 1751041 - Compute the process startup timestamp early during startup r=glandium

Previously the process startup timestamp was computed lazily but this caused
some issues with some of our static analysis infra (see bug 1678152). This
moves computing the timestamp early during process startup and makes it happen
unconditionally.

Depends on D132736

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/034ae0e4c467
Compute the process startup timestamp early during startup r=glandium

Comment 3

[Noemi Erli[:noemi_erli]]

Backed out 2 changesets (Bug 1678152, Bug 1751041) for causing failures in test_missing_intermediate.js CLOSED TREE

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&selectedTaskRun=AL4hr4FKRB-mmkyN9M8jag.0&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=034ae0e4c467bc707be98717de6c2963db95c1a4

Log: https://treeherder.mozilla.org/logviewer?job_id=365391373&repo=autoland&lineNumber=8975

Backout: https://hg.mozilla.org/integration/autoland/rev/ea291de828a9258194e0a74ed91248b6764ceebc

Comment 4

[Gabriele Svelto [:gsvelto]]

I've inspected the issue and it's bug 1678152 causing it, so this can land on its own.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bb7e7b27398f
Compute the process startup timestamp early during startup r=glandium

Comment 6

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/bb7e7b27398f