1751076 - Intermittent [TV] browser/components/downloads/test/browser/browser_downloads_context_menu_delete_file.js | At the start of the test, there should be 0 downloads - Got 1, expected +0

Status: RESOLVED FIXED

(Firefox :: Downloads Panel, defect, P5)

Description

[Treeherder Bug Filer]

Filed by: nbeleuzu [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer?job_id=364682368&repo=autoland
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/STq50sJNRMa2ny1QTbGj7g/runs/0/artifacts/public/logs/live_backing.log
Reftest URL: https://hg.mozilla.org/mozilla-central/raw-file/tip/layout/tools/reftest/reftest-analyzer.xhtml#logurl=https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/STq50sJNRMa2ny1QTbGj7g/runs/0/artifacts/public/logs/live_backing.log&only_show_unexpected=1

---

[task 2022-01-19T19:28:41.271Z] 19:28:41     INFO - TEST-START | browser/components/downloads/test/browser/browser_downloads_context_menu_delete_file.js
[task 2022-01-19T19:28:41.282Z] 19:28:41     INFO - TEST-INFO | started process screentopng
[task 2022-01-19T19:28:41.728Z] 19:28:41     INFO - TEST-INFO | screentopng: exit 0
[task 2022-01-19T19:28:41.728Z] 19:28:41     INFO - Buffered messages logged at 19:28:41
[task 2022-01-19T19:28:41.728Z] 19:28:41     INFO - Entering test bound test_download_deleteFile
[task 2022-01-19T19:28:41.728Z] 19:28:41     INFO - Buffered messages finished
[task 2022-01-19T19:28:41.732Z] 19:28:41     INFO - TEST-UNEXPECTED-FAIL | browser/components/downloads/test/browser/browser_downloads_context_menu_delete_file.js | At the start of the test, there should be 0 downloads - Got 1, expected +0
[task 2022-01-19T19:28:41.732Z] 19:28:41     INFO - Stack trace:
[task 2022-01-19T19:28:41.732Z] 19:28:41     INFO - chrome://mochikit/content/browser-test.js:test_is:1403
[task 2022-01-19T19:28:41.732Z] 19:28:41     INFO - chrome://mochitests/content/browser/browser/components/downloads/test/browser/browser_downloads_context_menu_delete_file.js:test_download_deleteFile:45
[task 2022-01-19T19:28:41.733Z] 19:28:41     INFO - Created download directory: /tmp/Temp-f95bbe96-eba4-4fe5-a83d-27b9684c3050/testsavedir2890449701
[task 2022-01-19T19:28:41.733Z] 19:28:41     INFO - Setting path for download file

Comment 1

[Andreea Pavel [:apavel]]

:Gijs, can you please take a look?

Comment 2

[Masatoshi Kimura [:emk]]

I encountered a similar problem when I was working on bug 1680139. Tests should clear finished downloads at exit.

Comment 3

[Shane Hughes [:aminomancer]]

I can move the check one line down so it'll clear downloads before checking. But it would be good to find out what made the download, I can make it log any info about the download so it can be tracked down

Comment 4

[Masatoshi Kimura [:emk]]

You don't have to clear downloads before the test starts. But you should clear downloads after the test ends so that subsequent tests (in this case subsequent iterations of the test itself) are not affected.

registerCleanupFunction would be useful. It will ensure the cleanup even if the test throws an exception unexpectedly.

Comment 5

[Shane Hughes [:aminomancer]]

I didn't duplicate task_resetState at the bottom because the menuitem is supposed to remove the download. I copied the template from another test which had task_resetState at the top. I assume it's not removing the download anymore due to the latest change to the pref

Comment 6

[Shane Hughes [:aminomancer]]

Attachment: Bug 1751076 - Fix downloads context menu delete file test. r=Gijs

The delete file menuitem in the downloads context menu no longer
removes the download list item on its own, so the test needs an
explicit cleanup callback to remove the download it creates.

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1750484

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9152f4686874
Fix downloads context menu delete file test. r=Gijs

Comment 9

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/9152f4686874

Comment 10

[Intermittent Failures Robot]

10 failures in 3444 pushes (0.003 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• autoland: 10

Platform and build breakdown:

• macosx1015-64-qr: 4
  • opt: 2
  • debug: 2
• windows10-64-2004-qr: 2
  • opt: 1
  • debug: 1
• linux1804-64-qr: 2
  • debug: 1
  • opt: 1
• windows10-32-2004-qr: 2
  • opt: 1
  • debug: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1751076&startday=2022-01-17&endday=2022-01-23&tree=all