1751154 - Consistent error handling for frameIds parameter in scripting API

Status: RESOLVED FIXED

(WebExtensions :: General, enhancement, P2)

Description

[William Durand [:willdurand]]

See: https://phabricator.services.mozilla.com/D133203#inline-749868

Comment 1

[William Durand [:willdurand]]

Attachment: Bug 1751154 - More consistent error handling for frameIds parameter in scripting API. r?robwu!

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7ba91106687b
More consistent error handling for frameIds parameter in scripting API. r=robwu

Comment 3

[Norisz Fay [:noriszfay]]

Backed out for causing mochitest failures on test_ext_tabs_executeScript.html

Backout link

Push with failures

Failure log for 3 // Failure log for bc

Failure line(s): TEST-UNEXPECTED-FAIL | mobile/android/components/extensions/test/mochitest/test_ext_tabs_executeScript.html | Got expected error - Expected: Frame not found, or missing host permission, Actual: Invalid frame IDs: [9007199254740991] // TEST-UNEXPECTED-FAIL | browser/components/extensions/test/browser/browser_ext_tabs_executeScript.js | Got expected error - Expected: Frame not found, or missing host permission, Actual: Invalid frame IDs: [9007199254740991]. -

Comment 4

[William Durand [:willdurand]]

oops, OK I didn't update these tests in the previous patch, sorry about that. I pushed a new revision and will autoland it when it gets approved.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ea7413cc34b5
More consistent error handling for frameIds parameter in scripting API. r=robwu

Comment 6

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/ea7413cc34b5