Closed Bug 1751170 Opened 3 years ago Closed 3 years ago

Rename network.http.http3.enabled

Categories

(Core :: Networking: HTTP, task, P3)

Product:
Core
Component:
Networking: HTTP
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
98 Branch
Tracking Flags:
Tracking Status
firefox98 --- fixed

People

(Reporter: dragana, Assigned: dragana)

References

(Blocks 1 open bug)

Details

(Whiteboard: [necko-triaged])

Attachments

(1 file)

Rename http3.enabled pref
48 bytes, text/x-phabricator-request
Details | Review
No description provided.

Since we're doing this, maybe we can change the HTTP2 pref as well. I find it odd that they're still nested under spdy. Maybe we can make them a bit nicer. And most of them can probably be converted to static prefs.

I will open another bug for the http2 prefs. This can be a good-first bug.

Pushed by ddamjanovic@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/d06323898333 Rename http3.enabled pref r=necko-reviewers,kershaw

Backed out for causing multiple build bustages on StaticPrefListAll.h.stub.

Push with failures

Failure log
Failure log for Linting opt Misc

Backout link

[task 2022-01-28T22:09:16.728Z] 22:09:16     INFO -  gmake[4]: Entering directory '/builds/worker/workspace/obj-build/modules/libpref'
[task 2022-01-28T22:09:16.728Z] 22:09:16     INFO -  modules/libpref/StaticPrefListAll.h.stub
[task 2022-01-28T22:09:16.729Z] 22:09:16     INFO -  /builds/worker/workspace/obj-build/_virtualenvs/build/bin/python -m mozbuild.action.file_generate /builds/worker/checkouts/gecko/modules/libpref/init/generate_static_pref_list.py emit_code init/StaticPrefListAll.h init/.deps/StaticPrefListAll.h.pp init/.deps/StaticPrefListAll.h.stub /builds/worker/checkouts/gecko/modules/libpref/init/StaticPrefList.yaml
[task 2022-01-28T22:09:16.729Z] 22:09:16    ERROR -  Traceback (most recent call last):
[task 2022-01-28T22:09:16.729Z] 22:09:16     INFO -    File "/usr/lib/python3.9/runpy.py", line 197, in _run_module_as_main
[task 2022-01-28T22:09:16.729Z] 22:09:16     INFO -      return _run_code(code, main_globals, None,
[task 2022-01-28T22:09:16.730Z] 22:09:16     INFO -    File "/usr/lib/python3.9/runpy.py", line 87, in _run_code
[task 2022-01-28T22:09:16.730Z] 22:09:16     INFO -      exec(code, run_globals)
[task 2022-01-28T22:09:16.730Z] 22:09:16     INFO -    File "/builds/worker/checkouts/gecko/python/mozbuild/mozbuild/action/file_generate.py", line 156, in <module>
[task 2022-01-28T22:09:16.730Z] 22:09:16     INFO -      sys.exit(log_build_task(main, sys.argv[1:]))
[task 2022-01-28T22:09:16.731Z] 22:09:16     INFO -    File "/builds/worker/checkouts/gecko/python/mozbuild/mozbuild/action/util.py", line 18, in log_build_task
[task 2022-01-28T22:09:16.731Z] 22:09:16     INFO -      return f(*args, **kwargs)
[task 2022-01-28T22:09:16.732Z] 22:09:16     INFO -    File "/builds/worker/checkouts/gecko/python/mozbuild/mozbuild/action/file_generate.py", line 100, in main
[task 2022-01-28T22:09:16.733Z] 22:09:16     INFO -      ret = module.__dict__[method](
[task 2022-01-28T22:09:16.735Z] 22:09:16     INFO -    File "/builds/worker/checkouts/gecko/modules/libpref/init/generate_static_pref_list.py", line 389, in emit_code
[task 2022-01-28T22:09:16.736Z] 22:09:16     INFO -      pref_list = yaml.safe_load(pp.out.getvalue())
[task 2022-01-28T22:09:16.737Z] 22:09:16     INFO -    File "/builds/worker/checkouts/gecko/third_party/python/PyYAML/lib3/yaml/__init__.py", line 162, in safe_load
[task 2022-01-28T22:09:16.738Z] 22:09:16     INFO -      return load(stream, SafeLoader)
[task 2022-01-28T22:09:16.739Z] 22:09:16     INFO -    File "/builds/worker/checkouts/gecko/third_party/python/PyYAML/lib3/yaml/__init__.py", line 114, in load
[task 2022-01-28T22:09:16.739Z] 22:09:16     INFO -      return loader.get_single_data()
[task 2022-01-28T22:09:16.739Z] 22:09:16     INFO -    File "/builds/worker/checkouts/gecko/third_party/python/PyYAML/lib3/yaml/constructor.py", line 49, in get_single_data
[task 2022-01-28T22:09:16.739Z] 22:09:16     INFO -      node = self.get_single_node()
[task 2022-01-28T22:09:16.740Z] 22:09:16     INFO -    File "/builds/worker/checkouts/gecko/third_party/python/PyYAML/lib3/yaml/composer.py", line 36, in get_single_node
[task 2022-01-28T22:09:16.740Z] 22:09:16     INFO -      document = self.compose_document()
[task 2022-01-28T22:09:16.740Z] 22:09:16     INFO -    File "/builds/worker/checkouts/gecko/third_party/python/PyYAML/lib3/yaml/composer.py", line 55, in compose_document
[task 2022-01-28T22:09:16.740Z] 22:09:16     INFO -      node = self.compose_node(None, None)
[task 2022-01-28T22:09:16.741Z] 22:09:16     INFO -    File "/builds/worker/checkouts/gecko/third_party/python/PyYAML/lib3/yaml/composer.py", line 82, in compose_node
[task 2022-01-28T22:09:16.741Z] 22:09:16     INFO -      node = self.compose_sequence_node(anchor)
[task 2022-01-28T22:09:16.741Z] 22:09:16     INFO -    File "/builds/worker/checkouts/gecko/third_party/python/PyYAML/lib3/yaml/composer.py", line 110, in compose_sequence_node
[task 2022-01-28T22:09:16.741Z] 22:09:16     INFO -      while not self.check_event(SequenceEndEvent):
[task 2022-01-28T22:09:16.742Z] 22:09:16     INFO -    File "/builds/worker/checkouts/gecko/third_party/python/PyYAML/lib3/yaml/parser.py", line 98, in check_event
[task 2022-01-28T22:09:16.742Z] 22:09:16     INFO -      self.current_event = self.state()
[task 2022-01-28T22:09:16.742Z] 22:09:16     INFO -    File "/builds/worker/checkouts/gecko/third_party/python/PyYAML/lib3/yaml/parser.py", line 382, in parse_block_sequence_entry
[task 2022-01-28T22:09:16.743Z] 22:09:16     INFO -      if self.check_token(BlockEntryToken):
[task 2022-01-28T22:09:16.743Z] 22:09:16     INFO -    File "/builds/worker/checkouts/gecko/third_party/python/PyYAML/lib3/yaml/scanner.py", line 116, in check_token
[task 2022-01-28T22:09:16.743Z] 22:09:16     INFO -      self.fetch_more_tokens()
[task 2022-01-28T22:09:16.743Z] 22:09:16     INFO -    File "/builds/worker/checkouts/gecko/third_party/python/PyYAML/lib3/yaml/scanner.py", line 223, in fetch_more_tokens
[task 2022-01-28T22:09:16.744Z] 22:09:16     INFO -      return self.fetch_value()
[task 2022-01-28T22:09:16.744Z] 22:09:16     INFO -    File "/builds/worker/checkouts/gecko/third_party/python/PyYAML/lib3/yaml/scanner.py", line 577, in fetch_value
[task 2022-01-28T22:09:16.744Z] 22:09:16     INFO -      raise ScannerError(None, None,
[task 2022-01-28T22:09:16.744Z] 22:09:16     INFO -  yaml.scanner.ScannerError: mapping values are not allowed here
[task 2022-01-28T22:09:16.745Z] 22:09:16     INFO -    in "<unicode string>", line 7309, column 7:
[task 2022-01-28T22:09:16.745Z] 22:09:16     INFO -        type: RelaxedAtomicBool
[task 2022-01-28T22:09:16.745Z] 22:09:16     INFO -            ^
[task 2022-01-28T22:09:16.745Z] 22:09:16    ERROR -  gmake[4]: *** [backend.mk:142: init/.deps/StaticPrefListAll.h.stub] Error 1
[task 2022-01-28T22:09:16.745Z] 22:09:16     INFO -  gmake[4]: Leaving directory '/builds/worker/workspace/obj-build/modules/libpref'
[task 2022-01-28T22:09:16.746Z] 22:09:16    ERROR -  gmake[3]: *** [/builds/worker/checkouts/gecko/config/recurse.mk:99: modules/libpref/export] Error 2
[task 2022-01-28T22:09:16.746Z] 22:09:16     INFO -  gmake[3]: *** Waiting for unfinished jobs....
[task 2022-01-28T22:09:16.769Z] 22:09:16     INFO -  gmake[3]: Entering directory '/builds/worker/workspace/obj-build'
Flags: needinfo?(dd.mozilla)

I notice a missing colon after name : name network.http.http3.enable

+# Enable HTTP/3
+- name network.http.http3.enable
+  type: RelaxedAtomicBool
+  value: true
+  mirror: always

This has been fixed.

Flags: needinfo?(dd.mozilla)
Pushed by ddamjanovic@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/f3ebfa5aa827 Rename http3.enabled pref r=necko-reviewers,kershaw

https://hg.mozilla.org/mozilla-central/rev/f3ebfa5aa827

Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox98: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 98 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: