1751196 - "binary" and "androidPackage" capabilities should be mutual exclusive

Status: RESOLVED FIXED

(Testing :: geckodriver, defect, P3)

Description

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Right now it's possible to pass both capabilities into New Session. As best geckodriver should fail and return a session not created error.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Attachment: Bug 1751196 - [geckodriver] androidPackage and binary capabilities are mutual exclusive.

It's only allowed to specify a desktop binary or an
Android package to start.

Depends on D137560

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/db30af103b55
[geckodriver] androidPackage and binary capabilities are mutual exclusive. r=webdriver-reviewers,jgraham

Comment 3

[Cristian Tuns]

Backed out for causing Btime failures

• Backout link
• Push with failures
• Failure Log

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+2]]

The problem here is that raptor-browsertime actually sets both the binary and androidPackage to workaround a selenium-webdriver issue:

https://searchfox.org/mozilla-central/rev/fe800a7fd291db3c4b3e498cfe12ef2097662290/testing/raptor/raptor/browsertime/android.py#82-88

This workaround was added around 2 years ago by bug 1565316. I'm going to push a try with these lines removed given that a lot has been changed in these 2 years and it might not be necessary anymore.

https://treeherder.mozilla.org/jobs?repo=try&revision=8cfeb10378b7b35615c7988821501388bfc7d7ec

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+2]]

The problem is still present with browsertime as the above try build demonstrates.

After some local checks I found out that the problematic piece is actually here:
https://github.com/sitespeedio/browsertime/blob/1fe163e18073e9e4d149c171f27bd26d2205f876/lib/firefox/webdriver/builder.js#L175-L177

Peter, can you please explain why a binary gets set in case of Android? It would be great if we can get this removed so that we can land our patch for geckodriver.

Comment 6

[Peter Hedenskog]

I think the reason is that we had Firefox support before we had Android Firefox support, so that was no thing in the beginning. I can fix that for the next release.

Comment 7

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Thanks a lot! So we can indeed wait until the next browsertime release and then land again.

Comment 8

[Henrik Skupin [:whimboo][⌚️UTC+2]]

A new browsertime release has been made with the fix included. I'm going to file a new bug for Raptor to get the used browsertime version updated (hint: run the command ./mach browsertime --update-upstream-url <TARBALL-URL>).

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d0954e9ba210
[geckodriver] androidPackage and binary capabilities are mutual exclusive. r=webdriver-reviewers,jgraham

Comment 10

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/d0954e9ba210