Closed Bug 1751364 Opened 4 months ago Closed 4 months ago

Invocation of certutil can fail because of invalid library path (from binary instead of certutil binary)

Categories

(Testing :: web-platform-tests, defect, P3)

Default
defect

Tracking

(firefox98 fixed)

RESOLVED FIXED
98 Branch
Tracking Status
firefox98 --- fixed

People

(Reporter: whimboo, Assigned: whimboo)

References

Details

Attachments

(1 file)

The invocation of certutil can fail for wdspec jobs in CI:

https://treeherder.mozilla.org/jobs?repo=try&revision=e2f70f7747d344e5dda134f822b9d3179664d393

[task 2022-01-11T21:42:14.543Z] 21:42:14 CRITICAL - subprocess.CalledProcessError: Command '['/builds/worker/workspace/build/hostutils/host-utils-93.0a1.en-US.linux-x86_64/certutil', '-N', '-d', '/tmp/tmprfyom2sb.mozrunner', '-f', '/tmp/tmprfyom2sb.mozrunner/.crtdbpw']' returned non-zero exit status 1.
[task 2022-01-11T21:42:14.745Z] 21:42:14 ERROR - Return code: 1

The reason for that is whenever a binary is passed-in to mach wpt the following code takes the Library path based on the binarie's directory instead of the explicitly stated certutils directory:

certutil_dir = os.path.dirname(self.binary or self.certutil_binary)

To fix that we should always use the directory of the certutil binary if specified, and if not fallback to the binary.

Attachment #9260080 - Attachment description: Bug 1751364 - [wptrunner] Use library path of custom certutil. r?jgraham → Bug 1751364 - [wptrunner] Don't pass binary path in mozharness script when on Android. r?jgraham
Pushed by hskupin@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a988f9123b0d
[wptrunner] Don't pass binary path in mozharness script when on Android. r=jgraham
Status: ASSIGNED → RESOLVED
Closed: 4 months ago
Resolution: --- → FIXED
Target Milestone: --- → 98 Branch
You need to log in before you can comment on or make changes to this bug.