1751434 - [wpt-sync] Sync PR 32494 - [inert] EnsureComputedStyle() for canvas fallback content focusability

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 32494 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/32494
Details from upstream follow.

Oriol Brufau <[e-mail]> wrote:

[inert] EnsureComputedStyle() for canvas fallback content focusability

Elements that are not rendered can still be focusable if they are inside
a canvas that is rendered. However, inertness should still prevent them
from being focusable.

But there is a problem: if they are in a display:none subtree, we won't
have a ComputedStyle to check IsInert(). In that case, the code was
assuming that it wouldn't be inert, but it was not great: forcing the
style computation with getComputedStyle() or other JS APIs could then
make the element be detected as inert, and thus stop being focusable.

This patch makes Element::IsFocusableStyle() use EnsureComputedStyle()
for elements inside a canvas, so that we can know whether they are
actually inert or not.

The problem is that this operation is not const, so a bunch of methods
related to focus need to stop being const.

TEST=external/wpt/inert/inert-canvas-fallback-content.tentative.html

Bug: 692360
Change-Id: Iae979322ac32df7e8ea68255be13be0419c9fc93
Cq-Do-Not-Cancel-Tryjobs: true
Reviewed-on: https://chromium-review.googlesource.com/3395837
WPT-Export-Revision: 68e8d5d6bd9ccc1e21a79391cae3002979fa42ac

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=da23805e3357e64d595c4443e27b206e1bb5c70f

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, and Chrome on GitHub CI

Total 6 tests and 12 subtests

Status Summary

Firefox

OK : 6
PASS: 49
FAIL: 3

Chrome

OK : 6
PASS: 25
FAIL: 27

Links

GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/inert/inert-canvas-fallback-content.tentative.html

  inert `div`
: FAIL (Chrome: PASS)

  inert `span`
: FAIL (Chrome: PASS)

  inert `a`
: FAIL (Chrome: FAIL)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f166703b6010
[wpt PR 32494] - [inert] Fix focusability of canvas descendants, a=testonly

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cbd7d2e9ac8b
[wpt PR 32494] - [inert] Fix focusability of canvas descendants, a=testonly

Comment 5

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/cbd7d2e9ac8b