1751443 - Don't count 0-channel device in AudioDeviceSet

Status: RESOLVED FIXED

(Core :: WebRTC: Audio/Video, defect, P1)

Description

[C.M.Chang[:chunmin]]

Per bug 1749281 comment 2 We should avoid creating 0-channel device

Comment 1

[C.M.Chang[:chunmin]]

Attachment: Bug 1751443 - Don't count 0-channel device in AudioDeviceSet

Comment 2

[C.M.Chang[:chunmin]]

Attachment: Bug 1751443 - Correct MockCubeb's device_collection_destroy

The cubeb_device_collection.count should be set to 0 in the
cubeb_device_collection_destroy.

Depends on D136629

Comment 3

[C.M.Chang[:chunmin]]

Attachment: Bug 1751443 - Fix style

Depends on D136641

Comment 4

[C.M.Chang[:chunmin]]

Attachment: Bug 1751443 - Add MockCubeb::DestroyDeviceCollection

Move implementation of cubeb_mock_device_collection_destroy to cpp file

Depends on D136642

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9223e2bf6ad5
Don't count 0-channel device in AudioDeviceSet r=padenot
https://hg.mozilla.org/integration/autoland/rev/e626fd455fef
Correct MockCubeb's device_collection_destroy r=padenot
https://hg.mozilla.org/integration/autoland/rev/8db5a7fbf5a9
Fix style r=padenot
https://hg.mozilla.org/integration/autoland/rev/0d2c7f4df16a
Add MockCubeb::DestroyDeviceCollection r=padenot

Comment 6

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/9223e2bf6ad5
https://hg.mozilla.org/mozilla-central/rev/e626fd455fef
https://hg.mozilla.org/mozilla-central/rev/8db5a7fbf5a9
https://hg.mozilla.org/mozilla-central/rev/0d2c7f4df16a

Comment 7

[Ryan VanderMeulen [:RyanVM]]

Please nominate this for Beta uplift when you get a chance.

Comment 8

[C.M.Chang[:chunmin]]

Comment on attachment 9260177 [details]
Bug 1751443 - Don't count 0-channel device in AudioDeviceSet

Beta/Release Uplift Approval Request

• User impact if declined: Users may crash during video conferencing
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This patch simply adds a check to validate the audio device. If the device is zero-channel, then we don't report it to the user so the user won't select the invalid device and then pass it to our system.
• String changes made/needed:

Comment 9

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9260177 [details]
Bug 1751443 - Don't count 0-channel device in AudioDeviceSet

Mostly just test changes. Fixes a crash. Approved for 97.0b9.

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/2c6a62c9c7ec
https://hg.mozilla.org/releases/mozilla-beta/rev/c45d4a4cebfa
https://hg.mozilla.org/releases/mozilla-beta/rev/7da0d150cf28
https://hg.mozilla.org/releases/mozilla-beta/rev/a627c9d80b68