Consider adding a debug pref to turn off flexbox optimization
Categories
(Core :: Layout: Flexbox, task)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox98 | --- | fixed |
People
(Reporter: TYLin, Assigned: TYLin)
Details
Attachments
(1 file)
I feel we often force the flex item's final reflow as a common trick when investigating flexbox sizing issues.
Daniel, do you feel it's worth landing your patch in bug 1747024 comment 9 permanently? An extra if in FlexItem::NeedsFinalReflow shouldn't impact the performance, and can also be useful to webcompat teams. If yes, I can work on a patch using StaticPref.
|
||
Comment 2•3 years ago
|
||
Yes, that seems like a useful diagnostic tool. Thanks for volunteering to work on a patch to add it!
Name-wise, we should make sure it's not something that users would feel tempted to toggle if they go poking around about:config looking to do their own performance-tuning.
|
|
||
Comment 3•3 years ago
|
||
(In particular, my layout.css.flex.perf.cache-final-reflow.disabled naming in bug 1747024's diagnostic patch is a bit clunky.)
Maybe better: layout.css.flex.skip-final-reflow.enabled
(Or s/skip/optimize-away/ perhaps -- a bit longer, but a bit clearer about "true" being the good/default setting.)
|
Assignee | |
Comment 4•3 years ago
|
||
|
||
Updated•3 years ago
|
|
|
||
Updated•3 years ago
|
Pushed by aethanyc@gmail.com: https://hg.mozilla.org/integration/autoland/rev/d56556c22163 Add a diagnostic preference to always run flex item's final reflow. r=dholbert
|
||
Comment 6•3 years ago
|
||
| bugherder | ||
Description
•