Closed Bug 1751482 Opened 3 years ago Closed 3 years ago

Don't email "revision updated" if diff unchanged

Categories

(Conduit :: Phabricator, enhancement, P3)

Product:
Conduit
Component:
Phabricator
Type:
enhancement

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: mhentges, Assigned: mhentges)

Details

(Keywords: conduit-triaged)

Attachments

(1 file)

GitHub Pull Request
54 bytes, text/x-github-pull-request
Details | Review

Theoretically, Phabricator has enough information at email-generation-time to be able to compare "visible" diffs between two versions of revisions.

If so, then we can remove the redundant "<user> has updated revision" email that is submitted for all the revisions in a stack re-submitted (but hardly affected) when a bottom revision is changed.

Assignee: nobody → mhentges
Status: NEW → ASSIGNED
Priority: -- → P3
Keywords: conduit-triaged

Merged to master.
https://github.com/mozilla-conduit/phabricator/commit/8e1dfa6cffc911e390ab8ffc00b8870c5115becc

Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: