1751673 - archlinux.ensure_nasm_packages parameter list has not been updated

Status: RESOLVED FIXED

(Firefox Build System :: Bootstrap Configuration, defect)

Description

[Jens Stutte [:jstutte]]

Error running mach:

    ['bootstrap']

The error occurred in code that was called by the mach command. This is either
a bug in the called code itself or in the way that mach is calling it.
You can invoke |./mach busted| to check if this issue is already on file. If it
isn't, please use |./mach busted file bootstrap| to report it. If |./mach busted| is
misbehaving, you can also inspect the dependencies of bug 1543241.

If filing a bug, please include the full output of mach, including this error
message.

The details of the failure are as follows:

TypeError: ArchlinuxBootstrapper.ensure_nasm_packages() missing 2 required positional arguments: 'state_dir' and 'checkout_root'

  File "/home/jens/src/mozilla-central/python/mozboot/mozboot/mach_commands.py", line 43, in bootstrap
    bootstrapper.bootstrap(command_context.settings)
  File "/home/jens/src/mozilla-central/python/mozboot/mozboot/bootstrap.py", line 374, in bootstrap
    self.maybe_install_private_packages_or_exit(application)
  File "/home/jens/src/mozilla-central/python/mozboot/mozboot/bootstrap.py", line 241, in maybe_install_private_packages_or_exit
    self.instance.ensure_nasm_packages()

Comment 1

[Jens Stutte [:jstutte]]

Attachment: Bug 1751673: Update archlinux.ensure_nasm_packages parameter list. r?#firefox-build-system-reviewers

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1747216

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/597902e6cd7b
Update archlinux.ensure_nasm_packages parameter list. r=firefox-build-system-reviewers,nalexander

Comment 4

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/597902e6cd7b

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:jstutte, is this bug important enough to require an uplift?
If not please set status_beta to wontfix.

For more information, please visit auto_nag documentation.

Comment 6

[Jens Stutte [:jstutte]]

Assuming that developers will start from central, I don't think this is needed to be uplifted.