HTML Select not working properly after 1750395
Categories
(GeckoView :: General, defect)
Tracking
(firefox-esr91 unaffected, firefox96 unaffected, firefox97 unaffected, firefox98blocking fixed)
| Tracking | Status | |
|---|---|---|
| firefox-esr91 | --- | unaffected |
| firefox96 | --- | unaffected |
| firefox97 | --- | unaffected |
| firefox98 | blocking | fixed |
People
(Reporter: anastasiostam, Assigned: emilio)
References
(Regression)
Details
(Keywords: regression)
Attachments
(1 file)
_handleselect function in GeckoViewPrompt.jsm expects the target, however the parent event is passed from handleEvent.
This is a major regression as HTML Select entities in Fenix are not working properly
|
Reporter | |
Updated•2 years ago
|
|
|
Reporter | |
Comment 1•2 years ago
|
||
I will try to make a patch for this
|
||
Updated•2 years ago
|
|
|
||
Comment 2•2 years ago
|
||
Set release status flags based on info from the regressing bug 1750395
|
|
||
Updated•2 years ago
|
|
||
Comment 3•2 years ago
|
||
Emilio it looks like this is a regression from one of your patches. Could you take a look please?
|
Assignee | |
Comment 4•2 years ago
|
||
Ugh, so we have zero automated test coverage for this? That's unfortunate, that's why I get for only testing that patch via try (I was traveling and couldn't do a full android build). Fixing :/
|
|
Assignee | |
Comment 5•2 years ago
|
||
We had zero coverage for this, apparently. Upon writing tests, the only
test we had for this was @Ignored :(
Write better tests for this. Add tests for <select multiple> which I
broke because the mozshowdropdown events only fire for dropdown selects.
I'm sorry anyways, I should've tested manually, but I was traveling and
found issues when trying to do an artifact build so I relied on try, oh
well.
Pushed by ealvarez@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/a5833843c7c8 Fix a couple issues with my patch for bug 1750395. r=agi
Pushed by emilio@crisal.io: https://hg.mozilla.org/integration/autoland/rev/66ff74439542 Appease eslint.
|
||
Comment 8•2 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/a5833843c7c8
https://hg.mozilla.org/mozilla-central/rev/66ff74439542
|
||
Updated•2 years ago
|
|
|
Reporter | |
Comment 10•2 years ago
|
||
Hello Emilio,
I tested this on the latest nightly Fenix and noticed the following:
- The first click-select works fine.
- The second time you click the "html select" it does nothing (it should have opened again the select popup)
Can you check if that is related to this bug?
It worked before on my installation of Fenix stable 96.0.2
(I checked with https://www.w3schools.com/tags/tryit.asp?filename=tryhtml_select )
|
|
Assignee | |
Comment 11•2 years ago
|
||
Thanks, bug 1752133 should fix that and another pre-existing issue.
Description
•