[wpt-sync] Sync PR 32512 - Must pass the right element to IsContainerForContainerQueries().
Categories
(Core :: Layout, task, P4)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox98 | --- | fixed |
People
(Reporter: wpt-sync, Unassigned)
References
()
Details
(Whiteboard: [wptsync downstream])
Sync web-platform-tests PR 32512 into mozilla-central (this bug is closed when the sync is complete).
PR: https://github.com/web-platform-tests/wpt/pull/32512
Details from upstream follow.
Morten Stenshorne <mstensho@chromium.org> wrote:
Must pass the right element to IsContainerForContainerQueries().
During interleaved layout and style recalculation we failed to stop at
the container query container when forcing legacy layout fallback,
because we passed the wrong element to ComputedStyle::
IsContainerForContainerQueries(). The element passed needs to be the one
that has/had/will have the style of |this|.Went through all the callsites for IsContainerForContainerQueries() to
make sure that it's being used correctly. The one in
ForceLegacyLayoutInFormattingContext() is what caused the problem, but
also found and corrected an additional one.Bug: 1289718
Change-Id: I2d2e88ad30cf29591f8c57360df88bc0491a491a
Reviewed-on: https://chromium-review.googlesource.com/3412093
WPT-Export-Revision: 728d3f5ac250869a81333d891ea2b0af1989c50d
|
Assignee | |
Updated•4 years ago
|
|
|
Assignee | |
Comment 1•4 years ago
|
||
|
|
Assignee | |
Comment 2•4 years ago
|
||
|
|
Assignee | |
Comment 3•4 years ago
|
||
CI Results
Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI
Total 2 tests
Status Summary
Firefox
PASS: 2
Chrome
PASS: 2
Safari
PASS: 2
Links
|
||
Comment 4•4 years ago
|
||
| bugherder | ||
Description
•