1751743 - Build failure in CollectStackingContextItems

Status: RESOLVED FIXED

(Core :: Web Painting, defect, P2)

Description

[[:fabrice] Fabrice Desré]

When MOZ_DIAGNOSTIC_ASSERT_ENABLED is enabled, https://searchfox.org/mozilla-central/rev/a2c26b9b49a521f4be39559ca1ca9c345a237c70/layout/painting/RetainedDisplayListBuilder.cpp#1588 fails to build because of https://searchfox.org/mozilla-central/rev/a2c26b9b49a521f4be39559ca1ca9c345a237c70/layout/painting/nsDisplayList.h#2865

I don't know if adding the matching #ifdef ... in RetainedDisplayListBuilder.cpp is the right fix or not.

Comment 1

[Miko Mynttinen]

(In reply to [:fabrice] Fabrice Desré from comment #0)

I don't know if adding the matching #ifdef ... in RetainedDisplayListBuilder.cpp is the right fix or not.

It is. Thank you for the report.

Comment 2

[Miko Mynttinen]

Attachment: Bug 1751743 - Add missing ifdef r=mstange

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1697979

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4c66080ca0d7
Add missing ifdef r=emilio

Comment 6

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/4c66080ca0d7

Comment 7

[Cristian Tuns]

The patch seems to be working in today's beta late simulation: https://treeherder.mozilla.org/jobs?repo=try&group_state=expanded&resultStatus=testfailed%2Cbusted%2Cexception%2Cusercancel&revision=dfa8b253a84e73d2e1a028c64329ae7332d2640d