1751831 - [wpt-sync] Sync PR 32522 - [block-in-inline] Keep a ref count for |PropagateBreakInfo|

Status: RESOLVED FIXED

(Core :: Layout: Columns, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 32522 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/32522
Details from upstream follow.

Koji Ishii <[e-mail]> wrote:

[block-in-inline] Keep a ref count for |PropagateBreakInfo|

When LayoutNGBlockInInline runtime flag is enabled,
|NGBoxFragmentBuilder::AddResult| retrieves the
|NGLayoutResult| of the block-in-inline.

Then when |AddLine| runs, it keeps |NGPhysicalFragment| but
may destroy |NGLayoutResult|, before |PropagateBreakInfo|
needs to use it.

This patch makes sure the ref count is kept until
|PropagateBreakInfo|.

Bug: 1289798
Change-Id: I99b07f26d3b35a8f0ea1d24c1ba8595244a1721d

Reviewed-on: https://chromium-review.googlesource.com/3414176
WPT-Export-Revision: 1b3c224f9f33711b57da267f3ec2e5f525f1a621

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=ffc8da68b2acef5ea7cc5e73dd26584168e97265

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests

Status Summary

Firefox

PASS: 1

Chrome

PASS: 1

Safari

PASS: 1

Links

GitHub PR Head
GitHub PR Base

Comment 3

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/043ba22cc724