1751832 - [wpt-sync] Sync PR 32523 - Check the end of the tree in |ShouldInsertSpaceBetweenObjectsIfNeeded|

Status: RESOLVED FIXED

(Testing :: web-platform-tests, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 32523 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/32523
Details from upstream follow.

Koji Ishii <[e-mail]> wrote:

Check the end of the tree in |ShouldInsertSpaceBetweenObjectsIfNeeded|

r927109 crrev.com/c/3185560 added a traversal to find block-
in-inline between |previous| and |next|, but there is a case
where |next| is not found by the DFS traversal.

This patch breaks the loop when it hits the end of the tree.

Bug: 1290123
Change-Id: I9d036de75bc6ae22b9c12185d940d059e781a2eb

Reviewed-on: https://chromium-review.googlesource.com/3414179
WPT-Export-Revision: 0ffc45c29c30ddba1782588d93428aff47fe9d93

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=fb2b95e5f7254eeecb0cc4be247827a784c9a8d8

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 11 Firefox configurations based on mozilla-central, and Firefox, and Chrome on GitHub CI

Total 1 tests

Status Summary

Firefox

TIMEOUT: 1

Chrome

TIMEOUT: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/css/CSS2/normal-flow/crashtests/block-in-inline-ax-crash.html: TIMEOUT (Chrome: TIMEOUT)

Comment 3

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/422db88ee7cf
https://hg.mozilla.org/mozilla-central/rev/0cbf3bf4e02f