1751879 - [wpt-sync] Sync PR 32528 - Some screen orientation API tests won't be passed since the order of event and promise is incorrect.

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 32528 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/32528
Details from upstream follow.

Makoto Kato <[e-mail]> wrote:

Some screen orientation API tests won't be passed since the order of event and promise is incorrect.

https://w3c.github.io/screen-orientation/#Screen-orientation-change

7.5 Screen orientation change
...
5. Fire an event named change at doc's Screen.orientation object.
6.1. Resolve doc's [[orientationPendingPromise]] with undefined.

change event is fired before the promise by lock() is resolved.
But onchange-event.html and orientation-reading.html wait for change
event after the promise is resolved.

So we shouldn't wait for the promise before calling wait_for.

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=ca13756e73d033ed7ab3a4c7f79007a6b32ea2aa

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 11 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 2 tests and 6 subtests

Status Summary

Firefox

PASS : 4
FAIL : 2
TIMEOUT: 2
ERROR : 2

Chrome

PASS : 4
FAIL : 2
TIMEOUT: 2
ERROR : 2

Safari

PASS : 1
FAIL : 7
ERROR : 2

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/screen-orientation/onchange-event.html: ERROR (Chrome: ERROR, Safari: ERROR)
Test that orientationchange event is not fired when the orientation does not change.: FAIL (Chrome: FAIL, Safari: FAIL)
Test that orientationchange event is fired when the orientation changes.: TIMEOUT (Chrome: TIMEOUT, Safari: FAIL)
/screen-orientation/orientation-reading.html: ERROR (Chrome: ERROR, Safari: ERROR)
Test the orientations and associated angles: FAIL (Chrome: FAIL, Safari: FAIL)
Test that screen.orientation values change if the orientation changes: TIMEOUT (Chrome: TIMEOUT, Safari: FAIL)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b4766ebfa963
[wpt PR 32528] - Some screen orientation API tests won't be passed since the order of event and promise is incorrect., a=testonly
https://hg.mozilla.org/integration/autoland/rev/ec6277d73053
[wpt PR 32528] - Update wpt metadata, a=testonly

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/27496283f172
[wpt PR 32528] - Some screen orientation API tests won't be passed since the order of event and promise is incorrect., a=testonly
https://hg.mozilla.org/integration/autoland/rev/4791c190c418
[wpt PR 32528] - Update wpt metadata, a=testonly

Comment 5

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/27496283f172
https://hg.mozilla.org/mozilla-central/rev/4791c190c418