Closed Bug 1751954 Opened 3 years ago Closed 3 years ago

Allow to return from waitForInitialNavigationCompleted when page started loading

Categories

(Remote Protocol :: Agent, enhancement, P2)

enhancement
Points:
2

Tracking

(firefox98 fixed)

RESOLVED FIXED
98 Branch
Tracking Status
firefox98 --- fixed

People

(Reporter: whimboo, Assigned: whimboo)

References

Details

(Whiteboard: [bidi-m3-mvp])

Attachments

(2 files)

Right now the method waitForInitialNavigationCompleted() does not support page load strategies and might cause issues for specific restart tests which want to have control before the page has been finished loading.

I would also like to have a way to override the default behavior of normal with none for emitting browsingContext.contextCreated events (bug 1694389). Given that for a onStateChange notification from the WebProgress there is already the information about the target URI (without possible redirects) which can be retrieved via the request argument, and would allow us to immediately return without having to wait for the page being loaded.

Assignee: nobody → hskupin
Status: NEW → ASSIGNED
Points: --- → 2

Actually this shared module will be available for all the protocols. As such it cannot support the PageLoadStrategy which is only a thing for WebDriver. Instead we can you a plain boolean.

Summary: waitForInitialNavigationCompleted has to support page load strategies → Allow to return from waitForInitialNavigationCompleted when page started loading
Attachment #9260987 - Attachment description: Bug 1751954 - [remote] Add support for page load strategy to waitForInitialNavigationCompleted. → Bug 1751954 - [remote] Allow to return from waitForInitialNavigationCompleted when load started.
Attachment #9261003 - Attachment description: Bug 1751954 - [marionette] Improve tests for PageLoadStrategy "None" in test_navigation.py. → Bug 1751954 - [marionette] Improve tests for PageLoadStrategy "none" in test_navigation.py.
Pushed by hskupin@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/9b70ae39e1c4
[remote] Allow to return from waitForInitialNavigationCompleted when load started. r=webdriver-reviewers,jdescottes
https://hg.mozilla.org/integration/autoland/rev/66cdd1411b5a
[marionette] Improve tests for PageLoadStrategy "none" in test_navigation.py. r=webdriver-reviewers,jgraham
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 98 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: