1751962 - scripting.executeScript should not execute in all frames by default

Status: RESOLVED FIXED

(WebExtensions :: General, defect, P2)

Description

[Rob Wu [:robwu]]

The scripting.executeScript implementation does currently not default to frameIds = [0]; at https://searchfox.org/mozilla-central/rev/02bd3e02b72d431f2c600a7328697a521f87d9b6/toolkit/components/extensions/parent/ext-scripting.js#75-79

That specific logic should be equivalent to https://searchfox.org/mozilla-central/rev/02bd3e02b72d431f2c600a7328697a521f87d9b6/toolkit/components/extensions/parent/ext-tabs-base.js#799-805.

The consequence of this missing check is that scripting.executeScript({ target: { tabId }, ...}) injects in all frames by default because of https://searchfox.org/mozilla-central/rev/02bd3e02b72d431f2c600a7328697a521f87d9b6/toolkit/components/extensions/parent/ext-tabs-base.js#700

Together with a fix, this consequence should be documented more explicitly at https://searchfox.org/mozilla-central/rev/02bd3e02b72d431f2c600a7328697a521f87d9b6/toolkit/components/extensions/parent/ext-tabs-base.js#684.

Comment 1

[William Durand [:willdurand]]

Attachment: Bug 1751962 - `scripting.executeScript()` should not execute in all frames by default. r?robwu!

Comment 2

[Rob Wu [:robwu]]

The script does not actually run in all frames because the implementation requires frameId to be set, allFrames true, or only injects in the top frame: https://searchfox.org/mozilla-central/rev/7fb9750a14e99267a77328559c2fd022e360d99b/toolkit/components/extensions/WebExtensionPolicy.cpp#696-705.

Comment 3

[William Durand [:willdurand]]

I attached a patch to fix the logic issue in parent/ext-scripting.js anyway and added test coverage.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0bca754139d7
`scripting.executeScript()` should not execute in all frames by default. r=robwu

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1736574

Comment 6

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/0bca754139d7