1752024 - Speed of two-finger back/forward touchpad swipe gestures affects idle time before going back/forward

Status: RESOLVED DUPLICATE of bug 1754674

(Core :: Widget: Win32, defect, P2)

Description

[Jürg Lempen]

User Agent: Mozilla/5.0 (Windows NT 10.0; rv:97.0) Gecko/20100101 Firefox/97.0

Steps to reproduce:

In Firefox 97 Beta 7, use the new two-finger back/forward touchpad swipe gestures to go back/forward in the navigation history. Perform several back and forward swipe gestures with different speeds and amplitudes.

Actual results:

The speed of the swipe gesture determines for how long Firefox shows the "arrow badge" on the left or right window edge before going back or forward in the navigation history.

With fast swipe gestures, the "arrow badge" gets stuck for one or two seconds after the gesture is finished (i.e. the fingers are removed from the touchpad) before going back or forward and displaying the previous or next page.

With slow swipe gestures, the "arrow badge" disappears as soon as the fingers are removed from the touchpad and the browser navigates back or forward immediately.

Expected results:

Firefox should hide the "arrow badge" and display the previous/next page as soon as the swipe gesture is finished (i.e. the fingers are removed from the touchpad), no matter how fast or slow the swipe gesture was performed by the user.

Implement the behaviour of Windows/Linux two-finger back/forward swipe gestures in a way that mimics the two-finger back/forward swipe gestures on the macOS version of Firefox.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Core::DOM: Navigation' component, and is moving the bug to that component. Please revert this change in case you think the bot is wrong.

Comment 2

[Hsin-Yi Tsai (she/her) [:hsinyi]]

Setting [qf] whiteboard to get Performance team's input on Severity/Priority.

Comment 3

[Greg Mierzwinski [:sparky]]

Hi Jürg, can you provide us with two profiles for a slow and a fast swipe?

Here you can find some instructions for creating the profile:

Performance recording (profile)

Profile URL:
(If this report is about slow performance or high CPU usage, please capture a performance profile by following the instructions at https://profiler.firefox.com/. Then upload the profile and insert the link here.)

Comment 4

[Jürg Lempen]

Hi Greg,

Here are the two profiles you requested.

Fast swipe back from reddit.com to duckduckgo.org and fast swipe forward from duckduckgo.org to reddit.com:
https://share.firefox.dev/3LehW5P

Slow swipe back from reddit.com to duckduckgo.org and slow swipe forward from duckduckgo.org to reddit.com:
https://share.firefox.dev/34p34B1

I hope this helps!

Comment 5

[Markus Stange [:mstange]]

Hiro, on macOS this issue does not appear - we navigate and hide the arrow as soon as the fingers are lifted from the touchpad. Can you take a look?

Comment 6

[Hiroyuki Ikezoe (:hiro)]

Markus, thanks for NI to me. I wasn't aware of this bug at all.

Jürg, thanks for reporting! I believe this bug has been fixed by bug 1754674. Would you mind trying the latest nightly to see whether it works or not? Thanks!

Comment 7

[Timothy Nikkel (:tnikkel)]

Changed version because we disabled swipe to nav on Windows before 97 release.

Comment 8

[Jürg Lempen]

Hi all,
This issue has indeed been fixed in the latest Nightly, thank you so much! It makes browsing the Web so much easier on a laptop!

I think we can close this bug now.

Thanks again and cheers from Switzerland!