1752047 - VO constantly announces 'in dialog, content is empty' when navigating ff content and UI

Status: VERIFIED FIXED

(Core :: Disability Access APIs, defect)

Description

[Morgan Reschenberg [:morgan]]

STR:

1. Enable VoiceOver
2. Navigate the tab strip

Expected:
VO reads the open tabs

Actual:
VO begins to read the open tabs but interrupts itself to say "in dialog, content is empty" after every navigation

I think this might be fallout from the quicksearch announcement implementation, but I'm not sure. I'll tag that bug as a see-also once I find it.

Comment 1

[Morgan Reschenberg [:morgan]]

Ah this has to do with tooltips:
STR:

1. Enable event logging for VO
2. Launch data:text/html,<button title="I am a tooltip">hello world</button><br><button>I have no tooltip</button>
3. Focus the first button

Expected:
VO reads the button name "hello world" and after a pause, reads the tooltip text but does not focus it. No further announcements are made.
VO reads the button name "I have no tooltip"

Actual:
VO gets the following notifications:

[AXCreated] dialog : AXRole=AXWindow AXTitle= AXDescription= AXValue=
[AXWindowCreated] dialog : AXRole=AXWindow AXTitle= AXDescription= AXValue=

and says the above string about dialogs

This doesn't happen if you focus an item with no tooltips (ie. the latter button)

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1742877

Comment 3

[Stephen A Pohl [:spohl]]

Morgan, unfortunately I was unable to reproduce this issue that you reported. Voice Over seems to work correctly for me, even after the patch in bug 1742877. I also couldn't figure out how to enable event logging for VO. However, I wrote a speculative fix and kicked off a try build. Could you run this build once it becomes available and let me know if that fixes things for you?

https://treeherder.mozilla.org/jobs?repo=try&revision=d5ee18113c1c96db64cded820e32bf32e2d5ae87

Comment 4

[Morgan Reschenberg [:morgan]]

Just applied the patch locally -- that fixes it for me!

Comment 5

[Stephen A Pohl [:spohl]]

Attachment: Bug 1752047: Ensure that Voice Over continues to function correctly for elements with tooltips. r=mstange

Comment 6

[Stephen A Pohl [:spohl]]

(In reply to Morgan Reschenberg [:morgan] from comment #4)

Just applied the patch locally -- that fixes it for me!

Thanks for confirming!

Comment 7

[Morgan Reschenberg [:morgan]]

Oh, I think in order for VO to generate tooltips, you need to enable Mouse pointer: Follows VO Cursor in VoiceOver Utility.app > Navigation. I'm not sure if it's enabled by default.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8d2153292ac4
Ensure that Voice Over continues to function correctly for elements with tooltips. r=mstange

Comment 9

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/8d2153292ac4

Comment 10

[Ryan VanderMeulen [:RyanVM]]

Is this something we'd want to fix in 97.0rc2 to avoid shipping the regression? Please nominate the patch for release approval ASAP if so.

Comment 11

[Stephen A Pohl [:spohl]]

Comment on attachment 9261794 [details]
Bug 1752047: Ensure that Voice Over continues to function correctly for elements with tooltips. r=mstange

Beta/Release Uplift Approval Request

• User impact if declined: Users using accessibility tools on macOS such as Voice Over may be unable to get page elements read to them if those elements contain a tooltip.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This patch reduces the scope of the original patch that was introduced in bug 1742877.
• String changes made/needed: none

Comment 12

[Stephen A Pohl [:spohl]]

(In reply to Ryan VanderMeulen [:RyanVM] from comment #10)

Is this something we'd want to fix in 97.0rc2 to avoid shipping the regression? Please nominate the patch for release approval ASAP if so.

I believe Morgan would like to see this patch uplifted. It is difficult for me to determine how many users might be affected by this, but since we're reducing the scope of the original patch from bug 1742877, I believe this is safe to uplift.

Since I wasn't able to reproduce the issue reported here I wasn't able to confirm the fix in Nightly. Morgan, would you be able to verify that this works as expected in Nightly now? Thank you!

Comment 13

[Morgan Reschenberg [:morgan]]

Confirmed fixed in Nightly :) If it's possible to uplift, we should.
:spohl do you want to file the req or should I? :)
Thanks again for the quick turnaround on this

Comment 14

[Stephen A Pohl [:spohl]]

(In reply to Morgan Reschenberg [:morgan] from comment #13)

Confirmed fixed in Nightly :) If it's possible to uplift, we should.
:spohl do you want to file the req or should I? :)
Thanks again for the quick turnaround on this

I already did since I was anticipating this to be fixed in Nightly (see comment 11), but in addition, it's now confirmed to be fixed in Nightly. Thanks, Morgan!

Comment 15

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9261794 [details]
Bug 1752047: Ensure that Voice Over continues to function correctly for elements with tooltips. r=mstange

Approved for 97.0rc2.

Comment 16

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-release/rev/b691bce5b61a

Comment 17

[Timea Zsoldos [:tzsoldos], Desktop QA]

I have reproduced this issue using Firefox 98.0a1 (2022.01.25) on macOS 10.15.
I can confirm this issue is fixed, I verified using Firefox 98.0a1 (latest nightly) and Firefox 97.0rc2 build on macOS 10.15.