1752183 - Support retrieving and displaying images stored as Remote Settings attachments in messaging system

Status: RESOLVED FIXED

(Firefox :: Messaging System, task, P1)

Description

[Barret Rennie [:barret] (they/them)]

We want to be able to ship images off train to Firefoxen, just like we do with RemoteL10n, using Remote Settings.

Comment 1

[Barret Rennie [:barret] (they/them)]

Attachment: Bug 1752183 - Add support for downloading and presenting remote images r?mardak

RemoteImages provides the capability to download and cache images to Firefoxen
off of release trains, e.g., to be used in Nimbus experiments. RemoteImages only returns
data URIs with the image content base64-encoded to avoid allowing file: URIs in
Content Security Policy. Additionally, images are only loaded from disk if
their SHA 256 checksum matches.

Images are cached for a maximum of 30 days, after which they will be deleted.

Comment 2

[Barret Rennie [:barret] (they/them)]

Attachment: Bug 1752183 - Support remote images in Spotlight r?mardak

Depends on D137209

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c4bd523a463a
Add support for downloading and presenting remote images r=Mardak
https://hg.mozilla.org/integration/autoland/rev/b85880f20aa5
Support remote images in Spotlight r=Mardak

Comment 4

[Iulian Moraru]

Backed out for causing multiple failures.

Push with failures

Failure log for bc when it first fails on browser_asrouter_remoteimages.js
Failure log TV for when it first fails on browser_asrouter_spotlight.js
Failure log for Linux 18.04 x64 opt Node

Backout link

[task 2022-02-03T05:17:04.478Z] 05:17:04     INFO - TEST-START | browser/components/newtab/test/browser/browser_asrouter_remoteimages.js
[task 2022-02-03T05:17:04.628Z] 05:17:04     INFO - GECKO(1582) | JavaScript error: resource://testing-common/RemoteImagesTestUtils.jsm, line 84: NS_ERROR_FILE_NOT_FOUND: Component returned failure code: 0x80520012 (NS_ERROR_FILE_NOT_FOUND) [nsIFileInputStream.init]
[task 2022-02-03T05:17:04.638Z] 05:17:04     INFO - GECKO(1582) | JavaScript error: resource://testing-common/RemoteImagesTestUtils.jsm, line 84: NS_ERROR_FILE_NOT_FOUND: Component returned failure code: 0x80520012 (NS_ERROR_FILE_NOT_FOUND) [nsIFileInputStream.init]
[task 2022-02-03T05:17:04.647Z] 05:17:04     INFO - GECKO(1582) | JavaScript error: resource://testing-common/RemoteImagesTestUtils.jsm, line 84: NS_ERROR_FILE_NOT_FOUND: Component returned failure code: 0x80520012 (NS_ERROR_FILE_NOT_FOUND) [nsIFileInputStream.init]
[task 2022-02-03T05:17:04.652Z] 05:17:04     INFO - TEST-INFO | started process screentopng
[task 2022-02-03T05:17:05.104Z] 05:17:05     INFO - TEST-INFO | screentopng: exit 0
[task 2022-02-03T05:17:05.105Z] 05:17:05     INFO - Buffered messages logged at 05:17:04
[task 2022-02-03T05:17:05.106Z] 05:17:05     INFO - Entering test bound test_remoteImages_load
[task 2022-02-03T05:17:05.106Z] 05:17:05     INFO - Console message: [JavaScript Error: "NS_ERROR_FILE_NOT_FOUND: Component returned failure code: 0x80520012 (NS_ERROR_FILE_NOT_FOUND) [nsIFileInputStream.init]" {file: "resource://testing-common/RemoteImagesTestUtils.jsm" line: 84}]
[task 2022-02-03T05:17:05.106Z] 05:17:05     INFO - Console message: [JavaScript Error: "NS_ERROR_FILE_NOT_FOUND: Component returned failure code: 0x80520012 (NS_ERROR_FILE_NOT_FOUND) [nsIFileInputStream.init]" {file: "resource://testing-common/RemoteImagesTestUtils.jsm" line: 84}]
[task 2022-02-03T05:17:05.106Z] 05:17:05     INFO - Console message: [JavaScript Error: "NS_ERROR_FILE_NOT_FOUND: Component returned failure code: 0x80520012 (NS_ERROR_FILE_NOT_FOUND) [nsIFileInputStream.init]" {file: "resource://testing-common/RemoteImagesTestUtils.jsm" line: 84}]
[task 2022-02-03T05:17:05.106Z] 05:17:05     INFO - Buffered messages finished
[task 2022-02-03T05:17:05.107Z] 05:17:05     INFO - TEST-UNEXPECTED-FAIL | browser/components/newtab/test/browser/browser_asrouter_remoteimages.js | Uncaught exception - at resource://services-settings/Attachments.jsm:27 - BadContentError: main/ms-images/about-robots.png content does not match server hash
[task 2022-02-03T05:17:05.108Z] 05:17:05     INFO - Stack trace:
[task 2022-02-03T05:17:05.108Z] 05:17:05     INFO - BadContentError@resource://services-settings/Attachments.jsm:27:5
[task 2022-02-03T05:17:05.109Z] 05:17:05     INFO - downloadAsBytes@resource://services-settings/Attachments.jsm:353:15
[task 2022-02-03T05:17:05.110Z] 05:17:05     INFO - Not taking screenshot here: see the one that was previously logged
[task 2022-02-03T05:17:05.113Z] 05:17:05     INFO - TEST-UNEXPECTED-FAIL | browser/components/newtab/test/browser/browser_asrouter_remoteimages.js | A promise chain failed to handle a rejection: Component returned failure code: 0x80520012 (NS_ERROR_FILE_NOT_FOUND) [nsIFileInputStream.init] - stack: serveRemoteImages/<@resource://testing-common/RemoteImagesTestUtils.jsm:84:16
[task 2022-02-03T05:17:05.113Z] 05:17:05     INFO - handleResponse@resource://testing-common/httpd.js:2495:36
[task 2022-02-03T05:17:05.113Z] 05:17:05     INFO - process@resource://testing-common/httpd.js:1354:26
[task 2022-02-03T05:17:05.113Z] 05:17:05     INFO - _handleResponse@resource://testing-common/httpd.js:1801:22

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/32709bd6d77c
Add support for downloading and presenting remote images r=Mardak
https://hg.mozilla.org/integration/autoland/rev/ffe8a1fe7113
Support remote images in Spotlight r=Mardak

Comment 6

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/32709bd6d77c
https://hg.mozilla.org/mozilla-central/rev/ffe8a1fe7113