1752191 - [WEBHOOKS] Allow Webhook Setup with "Any" Product

Status: RESOLVED FIXED

(bugzilla.mozilla.org :: API, enhancement)

Description

[Bryan Sieber [ :bsieber ]]

As part of JBI, there's an interest to access the full flow of bugzilla events; by adding an "Any" option for the Product dropdown this could be one webhook.

Currently there ~182 Products, an alternate option is to construct a webhook per product.

What would the load of events/sec look like with this?

Comment 1

[David Lawrence [:dkl]]

We can work on this but it will be Q2 at the earliest due to a couple of other important features that need to be completed first.

Notes to self:

• We will create a special group that will allow a user to select ANY product. Only members of the group will be allowed
• Bugs filed in specific products that the webhook owner cannot see will be filtered out and not sent.
• Bugs that are marked secure will be sent only if the webhook owner has permission to see the bug.
• After a specified number of failures, the webhook will be automatically disabled and no future calls will be made.
• Bugzilla will send a notification to the webhook owner when the failure threshold has been hit and the webhook is disabled. The owner can then try to figure out what is wrong and re-enable it.

Comment 2

[David Lawrence [:dkl]]

(In reply to David Lawrence [:dkl] from comment #1)

We can work on this but it will be Q2 at the earliest due to a couple of other important features that need to be completed first.

Notes to self:

• We will create a special group that will allow a user to select ANY product. Only members of the group will be allowed
• Bugs filed in specific products that the webhook owner cannot see will be filtered out and not sent.
• Bugs that are marked secure will be sent only if the webhook owner has permission to see the bug.
• After a specified number of failures, the webhook will be automatically disabled and no future calls will be made.
• Bugzilla will send a notification to the webhook owner when the failure threshold has been hit and the webhook is disabled. The owner can then try to figure out what is wrong and re-enable it.

Going to break this up into smaller bugs as some of the changes are more universal and will affect all webhooks.

For this bug it will just be the ability to specify product == 'Any' to get all notifications. The other bugs will deal with the disabling of webhooks for over load of failures and the notifications sent out.

Comment 3

[David Lawrence [:dkl]]

Attachment: GitHub Pull Request

Comment 4

[David Lawrence [:dkl]]

Merged to master.
https://github.com/mozilla-bteam/bmo/commit/5c31ec0e594075cd3d466eeefbd82d303a6cfb38

Comment 5

[David Lawrence [:dkl]]

bsieber, this change is now live in productions. I have made the group who can select Product to 'Any' to be the mozilla-employee-confidential group for now to limit the exposure. You should be able to create a webhook that sends messages for all changes for all products. Please try it out and let me know if it works for you.

Comment 6

[Jira Integration Bot]

Thanks :dkl! Apologies for the delay, I was OOO; I'll test this out in staging next week and get back to you.

Comment 7

[Bryan Sieber [ :bsieber ]]

Attachment: Screen Shot 2022-05-25 at 6.48.59 PM.png

Comment 8

[Bryan Sieber [ :bsieber ]]

Hi DKL, I was looking to add this into staging but haven't been able to use the 'ANY' Product; does there need to be a toggle enabled for [e-mail] on https://bugzilla-dev.allizom.org/userprefs.cgi?tab=webhooks

Comment 9

[David Lawrence [:dkl]]

(In reply to Bryan Sieber [ :bsieber ] from comment #8)

Hi DKL, I was looking to add this into staging but haven't been able to use the 'ANY' Product; does there need to be a toggle enabled for [e-mail] on https://bugzilla-dev.allizom.org/userprefs.cgi?tab=webhooks

Ah yes. 1) I need to update bugzilla-dev with the latest code that is live on production and 2) I need to create the group and assign you to it that allows to choose 'Any' as a product. Will do that shortly.

Comment 10

[David Lawrence [:dkl]]

(In reply to David Lawrence [:dkl] from comment #9)

(In reply to Bryan Sieber [ :bsieber ] from comment #8)

Hi DKL, I was looking to add this into staging but haven't been able to use the 'ANY' Product; does there need to be a toggle enabled for [e-mail] on https://bugzilla-dev.allizom.org/userprefs.cgi?tab=webhooks

Ah yes. 1) I need to update bugzilla-dev with the latest code that is live on production and 2) I need to create the group and assign you to it that allows to choose 'Any' as a product. Will do that shortly.

Should be enabled now on bugzilla-dev.allizom.org for testing.