Closed Bug 1752194 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 32560 - Fragmented OOF in inline crash

Categories

(Core :: Layout, task, P4)

task

Tracking

()

RESOLVED FIXED
99 Branch
Tracking Status
firefox99 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(Depends on 1 open bug, )

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 32560 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/32560
Details from upstream follow.

Alison Maher <almaher@microsoft.com> wrote:

Fragmented OOF in inline crash

When an OOF is fragmented, we wait to lay it out at the fragmentation
context root. If the OOF lives above a column spanner, though, we may
lay it out early to make sure the OOF contributes to the correct column
block-size (CL:3018723).

However, if a re-attach is triggered, we may end up with old fragments
sticking around until a node has completed layout (as a result of
CL:3393649).

This created an issue when an OOF is laid out early as a result of a
columns spanner break. The OOF algorithm would attempt to access
old fragments since they are no longer cleared out by default in
LayoutBox::AddLayoutResult(). To handle this, remove all old items
not only when the node has completed layout, but also if an item broke
as a result of a column spanner.

Bug: 1290093
Change-Id: I9b47ea681534f59ad6d1ed0662238306fcc03381

Reviewed-on: https://chromium-review.googlesource.com/3415692
WPT-Export-Revision: 5926cedab75cfacb0b8e15be51fe1405a5e4a9b0

Component: web-platform-tests → Layout
Product: Testing → Core

CI Results

Ran 11 Firefox configurations based on mozilla-central, and Firefox, and Chrome on GitHub CI

Total 1 tests

Status Summary

Firefox

PASS: 1

Chrome

PASS: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/584c3e005a8b [wpt PR 32560] - Fragmented OOF in inline crash, a=testonly
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/c208c9a34e7f [wpt PR 32560] - Fragmented OOF in inline crash, a=testonly
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 99 Branch
You need to log in before you can comment on or make changes to this bug.