1752200 - Failure to collect scrolling interaction data leads to the entire interaction being discarded

Status: RESOLVED FIXED

(Toolkit :: Places, defect)

Description

[Andrew Creskey [:acreskey]]

We collect the scrolling interactions data via promise and only add the interaction to the store on success:

https://searchfox.org/mozilla-central/rev/2e0ceee0158293a37466aaf9495dbeffef744b7c/browser/components/places/Interactions.jsm#389-405

However it would be better to save the interaction even if the scrolling data fails to return.

Comment 1

[Andrew Creskey [:acreskey]]

Patch incoming.

Comment 2

[Andrew Creskey [:acreskey]]

Attachment: Bug 1752200 - Failure to collect scrolling interaction data leads to the entire interaction being discarded r=mossop

We store the interaction regardless of success of the scrolling collection since it's better to at least store partial interaction data.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/248c737ec856
Failure to collect scrolling interaction data leads to the entire interaction being discarded r=mossop

Comment 4

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/248c737ec856