Closed Bug 1752200 Opened 2 years ago Closed 2 years ago

Failure to collect scrolling interaction data leads to the entire interaction being discarded

Categories

(Toolkit :: Places, defect)

Product:
Toolkit
Component:
Places
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
98 Branch
Tracking Flags:
Tracking Status
firefox98 --- fixed

People

(Reporter: acreskey, Assigned: acreskey)

Details

Attachments

(1 file)

Bug 1752200 - Failure to collect scrolling interaction data leads to the entire interaction being discarded r=mossop
48 bytes, text/x-phabricator-request
Details | Review

We collect the scrolling interactions data via promise and only add the interaction to the store on success:

https://searchfox.org/mozilla-central/rev/2e0ceee0158293a37466aaf9495dbeffef744b7c/browser/components/places/Interactions.jsm#389-405

However it would be better to save the interaction even if the scrolling data fails to return.

Patch incoming.

We store the interaction regardless of success of the scrolling collection since it's better to at least store partial interaction data.

Attachment #9260923 - Attachment description: Bug 1752200 - Failure to collect scrolling interaction data leads to the entire interaction being discarded r= → Bug 1752200 - Failure to collect scrolling interaction data leads to the entire interaction being discarded r=mossop
Pushed by acreskey@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/248c737ec856
Failure to collect scrolling interaction data leads to the entire interaction being discarded r=mossop

https://hg.mozilla.org/mozilla-central/rev/248c737ec856

Status: NEW → RESOLVED
Closed: 2 years ago
status-firefox98: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 98 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: