1752212 - Standardize the ScriptPreloader/StartupCache cache key format

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task, P3)

Description

[Tooru Fujisawa [:arai]]

Currently there are multiple cache key format:

• nsXULPrototypeCache
  • "xulcache/" + URI path *
  • "nsXULPrototypeCache.startupCache"
• FontNameCache
  • "font.cached-list"
• gfxFT2FontList
  • "jar-last-modified-time"
• `mozJSComponentLoader
  • "jsloader/non-syntactic/" + URI path *
• mozJSSubScriptLoader
  • "jssubloader/non-syntactic/" + URI path *
  • "jssubloader/global/" + URI path *
• nsMessageManagerScriptExecutor (frame script, process script)
  • raw URI *

where items marded with * are Stencil.

So, only nsMessageManagerScriptExecutor uses raw URI, while others uses path-like key.
If we add the compilation target into the cache key string in bug 1752209, it's better having consistent format, for example:

• compilation target + "/" + loader type + "/" + URI path

Comment 1

[Tooru Fujisawa [:arai]]

(In reply to Tooru Fujisawa [:arai] from comment #0)

Currently there are multiple cache key format:

• nsXULPrototypeCache
  • "xulcache/" + URI path *

where items marded with * are Stencil.

this was not accurate.
the content of nsXULPrototypeCache can contain Stencil, but it's serialization of XUL tree, so it can contain multiple Stencils,
and it's not guaranteed to have single compilation target, if we support module in XUL.

So, the compilation target must be put into the key only for others that the cache corresponds to single .js file

Comment 2

[Tooru Fujisawa [:arai]]

(In reply to Tooru Fujisawa [:arai] from comment #1)

So, the compilation target must be put into the key only for others that the cache corresponds to single .js file

Or maybe the "compilation target" part can be extended to have "other", that can optionally be used by remaining consumers (not sure if it worth tho)

Comment 3

[Tooru Fujisawa [:arai]]

nsXULPrototypeScript::SerializeOutOfLine needs compilation target, because it's .js file referred from <script>
nsXULPrototypeCache::WritePrototype doesn't need it, because it's xul file

Comment 4

[Tooru Fujisawa [:arai]]

Attachment: Bug 1752212 - Part 1: Pass loader type to PathifyURI. r?nbp!

Comment 5

[Tooru Fujisawa [:arai]]

Attachment: Bug 1752212 - Part 2: Add loader type to cache key used by nsFrameMessageManager. r?nbp!

Depends on D143574

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e38fbd381ed3
Part 1: Pass loader type to PathifyURI. r=nbp
https://hg.mozilla.org/integration/autoland/rev/557c428fb6bc
Part 2: Add loader type to cache key used by nsFrameMessageManager. r=nbp

Comment 7

[Cristina Cozmuta (:CrissCozmuta)]

Backed out for causing build bustages . CLOSED TREE

Backout link: https://hg.mozilla.org/integration/autoland/rev/84a0dcf54a260865312c902466be7dbfe92b13ea

Push with failures : https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Crunnable&revision=8f10b666008a6ece0b513787ca332c766d11ce34&selectedTaskRun=BEZM8o5ATfODy8J6FG-2Cg.0

Link to failure log :
https://treeherder.mozilla.org/logviewer?job_id=374355320&repo=autoland&lineNumber=14215
https://treeherder.mozilla.org/logviewer?job_id=374351442&repo=autoland&lineNumber=25706

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6340c6d93f10
Part 1: Pass loader type to PathifyURI. r=nbp
https://hg.mozilla.org/integration/autoland/rev/7b7ac774209c
Part 2: Add loader type to cache key used by nsFrameMessageManager. r=nbp

Comment 9

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/6340c6d93f10
https://hg.mozilla.org/mozilla-central/rev/7b7ac774209c