1752281 - Improve CacheIR support for null/undefined/bool for unary/binary arithmetic ops

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, task, P3)

Description

[Jan de Mooij [:jandem]]

I have some patches that improve the micro-benchmark below from 580 ms to 9 ms locally.

Based on the profile there, this might help bug 1745639. These types also show up a number of times while browsing various websites.

function f(a, b) {
    var res = 0;
    for (var i = 0; i < 10_000_000; i++) {
        res = (a + i) + -b;
    }
    return res;
}
var t = new Date;
f(null, undefined);
print(new Date - t);

Comment 1

[Jan de Mooij [:jandem]]

Attachment: Bug 1752281 part 1 - Add support for CacheIR stub fields storing a double. r?iain!

This is similar to the Int64 stub fields we already support.

Comment 2

[Jan de Mooij [:jandem]]

Attachment: Bug 1752281 part 2 - Add LoadDoubleConstant CacheIR instruction. r?iain!

Depends on D137120

Comment 3

[Jan de Mooij [:jandem]]

Attachment: Bug 1752281 part 3 - Optimize null operand for binary arithmetic ops with int32 result. r?iain!

It's straight-forward to support null here in addition to int32 and boolean.

Depends on D137121

Comment 4

[Jan de Mooij [:jandem]]

Attachment: Bug 1752281 part 4 - Optimize boolean or null operand for unary arithmetic ops with int32 result. r?iain!

Depends on D137122

Comment 5

[Jan de Mooij [:jandem]]

Attachment: Bug 1752281 part 5 - Optimize null/undefined/boolean operands for binary arithmetic ops with double result. r?iain!

Depends on D137123

Comment 6

[Jan de Mooij [:jandem]]

Attachment: Bug 1752281 part 6 - Optimize null/undefined/boolean operands for unary arithmetic ops with double result. r?iain!

Depends on D137124

Comment 7

[Jan de Mooij [:jandem]]

Attachment: Bug 1752281 part 7 - Add tests. r?iain!

Depends on D137125

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b2931a447f7e
part 1 - Add support for CacheIR stub fields storing a double. r=iain
https://hg.mozilla.org/integration/autoland/rev/afb4a471cd8f
part 2 - Add LoadDoubleConstant CacheIR instruction. r=iain
https://hg.mozilla.org/integration/autoland/rev/b564ab08d861
part 3 - Optimize null operand for binary arithmetic ops with int32 result. r=iain
https://hg.mozilla.org/integration/autoland/rev/6bb50e480f6c
part 4 - Optimize boolean or null operand for unary arithmetic ops with int32 result. r=iain
https://hg.mozilla.org/integration/autoland/rev/aae92d923cca
part 5 - Optimize null/undefined/boolean operands for binary arithmetic ops with double result. r=iain
https://hg.mozilla.org/integration/autoland/rev/cd1d702f97b1
part 6 - Optimize null/undefined/boolean operands for unary arithmetic ops with double result. r=iain
https://hg.mozilla.org/integration/autoland/rev/1d6c7a604dd6
part 7 - Add tests. r=iain

Comment 9

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/b2931a447f7e
https://hg.mozilla.org/mozilla-central/rev/afb4a471cd8f
https://hg.mozilla.org/mozilla-central/rev/b564ab08d861
https://hg.mozilla.org/mozilla-central/rev/6bb50e480f6c
https://hg.mozilla.org/mozilla-central/rev/aae92d923cca
https://hg.mozilla.org/mozilla-central/rev/cd1d702f97b1
https://hg.mozilla.org/mozilla-central/rev/1d6c7a604dd6