1752347 - ESLint: Handle XPCOMUtils.define* using unary expressions when defining globals

Status: RESOLVED FIXED

(Developer Infrastructure :: Lint and Formatting, defect, P3)

Description

[Mark Banner (:standard8)]

Currently, this works for ESLint to recognise it and define snapshot_overlap_limit as a global:

XPCOMUtils.defineLazyPreferenceGetter(
  this,
  "snapshot_overlap_limit",
  "browser.places.interactions.snapshotOverlapLimit",
  1000
);

However this version does not:

XPCOMUtils.defineLazyPreferenceGetter(
  this,
  "snapshot_overlap_limit",
  "browser.places.interactions.snapshotOverlapLimit",
  -1
);

The issue is that the -1 is a unary expression and our AST source handler is not handling those expressions.

Comment 1

[Mark Banner (:standard8)]

Attachment: Bug 1752347 - ESLint: Handle XPCOMUtils.define* using unary expressions when defining globals. r?Mossop!

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/36e6e0798fe9
ESLint: Handle XPCOMUtils.define* using unary expressions when defining globals. r=mossop

Comment 3

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/36e6e0798fe9