17524 - context menu on links has "Bookmark this page"

Status: VERIFIED FIXED

(SeaMonkey :: General, defect, P3)

Description

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

DESCRIPTION:  If you right click on a link, the context menu has "Bookmark this
page", which adds a bookmark to the page being viewed (not the link).  It should
instead have an "add bookmark to link" item that adds a bookmark to the link.
Having the "bookmark this page" item is confusing - I expected it to bookmark
the link.

STEPS TO REPRODUCE:
 * load this page in apprunner
 * right click on a link
 * choose the bookmark-adding option

ACTUAL RESULTS:
 * the bookmark adding option is called "Bookmark this page"
 * it adds a bookmark to this page

EXPECTED RESULTS:
 * the bookmark adding option is called "Add bookmark for link"
 * it bookmarks the link

DOES NOT WORK CORRECTLY ON:
 * Linux, apprunner, 1999-10-28-08-M11

WORKS CORRECTLY ON:
 * NN 4.61 Linux

Comment 1

[Sean Richardson]

ALSO DOES NOT WORK CORRECTLY ON:
Windows NT, mozilla.exe, 1999-10-27-08-M11 binary

WORKS CORRECTLY ON:
Windows NT, Navigator 4.7

ADDITIONAL INFORMATION:
In NN 4.7, the item on the context menu is "Add Bookmark" both when right-
clicking on a link and on text/whitespace. The actual bookmark added is
correct for both, however.

Comment 2

[shuang (gone)]

german,
what should be an easy term for this one? I also re-set the mileston to m16 for
later fix.

Comment 3

[german]

I am tending towards thinking we need both. The link is added when you are
over a link and the page or frame will be added when you're not. I agree
with your wording concerns. Right now I believe only Bookmark This Page is
implimented anyway. We'll look at this a bit later.

Comment 4

[german]

How about 'Bookmark This Page' and 'Bookmark This Link'. cc'ing verah who is
owning instructional media and help for the browser.

Comment 5

[sairuh (rarely reading bugmail)]

spam: reassigning QA contact to self.

Comment 6

[verah (gone)]

I think German's proposed wording is fine. However, at some point I'd like to
look at the entire context menu for this, because in 4.x versions there are
several items (Add Bookmark, Create Shortcut, Save Link As.., and Copy Link
Location) and its difficult to figure out which does what.

Comment 7

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

*** Bug 23296 has been marked as a duplicate of this bug. ***

Comment 8

[german]

context menu review is in progress...

Comment 9

[leger]

Setting the keyword all open [4.xp] bugs to 4xp.

Comment 10

[leger]

Moving all UE/UI bugs to new component: User Interface: Design Feedback
UE/UI component will be deleted.

Comment 11

[shuang (gone)]

Need to pass this one to engineer to fix/add it. Who is the right person?

Comment 12

[verah (gone)]

If you re-assign it to Don, and change to no target milestone, we'll look at it 
on 5/11 and assign it to the right person.

Comment 13

[sairuh (rarely reading bugmail)]

done.

Comment 14

[verah (gone)]

Reassigning as per Don.

Comment 15

[don]

Move to M21 target milestone.

Comment 16

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Nominating for nsbeta3, since I think this is an important usability issue.

Comment 17

[verah (gone)]

Nav triage team: [nsbeta3+]

Comment 18

[Bill Law]

Attachment: Proposed fix

Comment 19

[Bill Law]

I've attached a proposed fix.  This patch also fixes a couple of other nagging 
context menu bugs.

Note that I do a depth-first recursion of the DOM under the <A> tag, looking for 
either some text or an alt= attribute on a <IMG> tag to use as the bookmark 
name.  This seems to work reasonably well.  Default is to fall back on the URL 
as the name.

I've asked [e-mail] to review.

Comment 20

[Robert O'Callahan (:roc) (email my personal email if necessary)]

It would also be cool to use the HTML TITLE attribute of the A element or one of
its children, if there is one.

Comment 21

[Bill Law]

Fix checked in.

Comment 22

[sairuh (rarely reading bugmail)]

vrfy fixed using opt comm bits. linux/mac, 2000.08.14.12; winnt 2000.08.15.08.