Enable VA-API by default in nightly
Categories
(Core :: Audio/Video: Playback, enhancement)
Tracking
()
Tracking | Status | |
---|---|---|
firefox103 | --- | fixed |
People
(Reporter: stransky, Assigned: stransky)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
If we want to enable VA-API by default we need to (at least):
- specify supported hardware and enable it only there
- make sure we fallback to SW decode if there's any problem
Assignee | ||
Updated•3 years ago
|
Assignee | ||
Comment 1•3 years ago
|
||
With Bug 1751363 fixed we may consider to enable it by default for Mesa/Intel/AMD users in Nightly/Beta.
Comment 2•3 years ago
|
||
Maybe these as well?
- The user has dual Intel/Nvidia (Optimus): Nvidia is disabled in BIOS, Intel is shown as the only graphics card.
- /usr/share/glvnd/egl_vendor.d/50_mesa.json and 10_nvidia.json exist, libglvnd prefers the lower number. The Nvidia driver is tried in RDD process and it crashes due to the sandbox. Too many RDD crashes at once cause a main process crash ([@ mozilla::PRDDChild::OtherPid ]).
- Even if the RDD sandbox would allow the Nvidia driver, it still might not reliably fall back to Mesa (bug 1745172), hopefully already handled by bug 1724385.
- Main process crash if VAAPIIsSupported hits vdpau_drv_video.so,
which callsXDisplayString(driver_data->x11_dpy)
, butvaGetDisplayDRM() doesn't fill ->x11_dpy
.
Assignee | ||
Comment 3•3 years ago
|
||
I think Mesa & Intel/AMD excludes any NVIDIA hardware (Bug 1758473).
Bug 1771382 is about fatal system misconfiguration which affects all GL applications, I don't think we can do anything here.
Comment 4•3 years ago
•
|
||
Intel is shown as the only graphics card.
My point was: How do you want to be sure that Nvidia hardware & driver are not involved?
What is the "fatal system misconfiguration"? "Having the Nvidia driver installed" or "disabling Nvidia in BIOS"?
Assignee | ||
Comment 5•3 years ago
|
||
(In reply to Darkspirit from comment #4)
Intel is shown as the only graphics card.
My point was: How do you want to be sure that Nvidia hardware & driver are not involved?
What is the "fatal system misconfiguration"? "Having the Nvidia driver installed"?
In Bug 1758473 NVIDIA is detected so we can disable VA-API.
Bug 1771382 is caused by wrong/incomplete NVIDIA binary drivers uninstall. It turns your box to broken state and we can't anything about it. I experienced that once by myself.
Comment 6•3 years ago
|
||
Good argument, thanks! Please proceed. :)
Verified: In case of problems, VAAPI can be force-disabled by setting media.hardware-video-decoding.enabled to false.
Assignee | ||
Updated•3 years ago
|
Assignee | ||
Comment 7•3 years ago
|
||
Updated•3 years ago
|
Updated•3 years ago
|
Updated•3 years ago
|
Comment 10•3 years ago
|
||
Martin, do we want to mention that change in out 103 nightly release notes?
https://wiki.mozilla.org/Release_Management/Release_Notes#Nomination_in_Bugzilla
Assignee | ||
Comment 11•3 years ago
|
||
(In reply to Pascal Chevrel:pascalc from comment #10)
Martin, do we want to mention that change in out 103 nightly release notes?
https://wiki.mozilla.org/Release_Management/Release_Notes#Nomination_in_Bugzilla
Yes, that would be great.
Assignee | ||
Comment 12•3 years ago
|
||
Release Note Request (optional, but appreciated)
[Why is this notable]: Firefox enables hardware video decoding on Linux by default. It's used on Intel/AMD platform when VA-API is available.
[Affects Firefox for Android]: no
[Suggested wording]:
[Links (documentation, blog post, etc)]:
Comment 13•3 years ago
•
|
||
Note added to 103 nightly release notes
Comment 14•2 years ago
|
||
Clearing the relnote flag since this will not be added to the 103 release notes in beta/release
Description
•