1752576 - glean_parser data-review shouldn't print a template if it didn't match any bugs

Status: RESOLVED FIXED

(Data Platform and Tools :: Glean: SDK, enhancement, P1)

Description

[Chris H-C :chutten]

If you call glean_parser data-review <non_existent_bug_number> it will happily spit out a Data Review Request template with no metrics in it.

I think it'd probably be better ergonomics if we instead outputted a message like

Sorry, we couldn't find any metrics in <metrics_yaml_list> matching bug number <non_existent_bug_number>.

Comment 1

[Chris H-C :chutten]

While you're here, perhaps we could also make it so that permanent collections have, instead of TODO: identify at least one individual here something like ",".join(notification_emails)? It's one more question we can fill for folks.

Comment 2

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/glean_parser/pull/447

Comment 3

[Chris H-C :chutten]

chutten merged PR #447: "bug 1752576 - data-review knows emails, and when the list is empty" in 0f63148.