1752623 - Crash [@ GetBoolFlag]

Status: RESOLVED FIXED

(Core :: Graphics: WebGPU, defect)

Description

[Jason Kratzer [:jkratzer]]

Testcase found while fuzzing mozilla-central rev 48e8fb0b62c5 (built with: --enable-address-sanitizer --enable-fuzzing).

Testcase can be reproduced using the following commands:

$ pip install fuzzfetch grizzly-framework
$ python -m fuzzfetch --build 48e8fb0b62c5 --asan --fuzzing -n firefox
$ python -m grizzly.replay ./firefox/firefox testcase.html --repeat 10 --relaunch 1 --time-limit 45

[@ GetBoolFlag]

    =================================================================
    ==3146062==ERROR: AddressSanitizer: SEGV on unknown address 0x00000000001c (pc 0x7f23b12ce3c6 bp 0x7ffd1a350c90 sp 0x7ffd1a350c80 T0)
    ==3146062==The signal is caused by a READ memory access.
    ==3146062==Hint: address points to the zero page.
        #0 0x7f23b12ce3c6 in GetBoolFlag /builds/worker/workspace/obj-build/dist/include/nsINode.h:1809:12
        #1 0x7f23b12ce3c6 in IsInUncomposedDoc /builds/worker/workspace/obj-build/dist/include/nsINode.h:692:43
        #2 0x7f23b12ce3c6 in nsIContent::GetPrimaryFrame() const /builds/worker/workspace/obj-build/dist/include/nsIContent.h:558:13
        #3 0x7f23b4755447 in mozilla::dom::HTMLCanvasElement::InvalidateCanvasContent(mozilla::gfx::RectTyped<mozilla::gfx::UnknownUnits, float> const*) /dom/html/HTMLCanvasElement.cpp:1147:21
        #4 0x7f23b436c6bb in mozilla::webgpu::CommandBuffer::Commit() /dom/webgpu/CommandBuffer.cpp:46:19
        #5 0x7f23b4388f34 in mozilla::webgpu::Queue::Submit(mozilla::dom::Sequence<mozilla::OwningNonNull<mozilla::webgpu::CommandBuffer> > const&) /dom/webgpu/Queue.cpp:30:40
        #6 0x7f23b34311d0 in mozilla::dom::GPUQueue_Binding::submit(JSContext*, JS::Handle<JSObject*>, void*, JSJitMethodCallArgs const&) /builds/worker/workspace/obj-build/dom/bindings/WebGPUBinding.cpp:19551:24
        #7 0x7f23b3c6320d in bool mozilla::dom::binding_detail::GenericMethod<mozilla::dom::binding_detail::NormalThisPolicy, mozilla::dom::binding_detail::ThrowExceptions>(JSContext*, unsigned int, JS::Value*) /dom/bindings/BindingUtils.cpp:3306:13
        #8 0x7f23bb8a4d14 in CallJSNative /js/src/vm/Interpreter.cpp:425:13
        #9 0x7f23bb8a4d14 in js::InternalCallOrConstruct(JSContext*, JS::CallArgs const&, js::MaybeConstruct, js::CallReason) /js/src/vm/Interpreter.cpp:512:12
        #10 0x7f23bb891145 in CallFromStack /js/src/vm/Interpreter.cpp:576:10
        #11 0x7f23bb891145 in Interpret(JSContext*, js::RunState&) /js/src/vm/Interpreter.cpp:3309:16
        #12 0x7f23bb875fa1 in js::RunScript(JSContext*, js::RunState&) /js/src/vm/Interpreter.cpp:394:13
        #13 0x7f23bb8a4e4f in js::InternalCallOrConstruct(JSContext*, JS::CallArgs const&, js::MaybeConstruct, js::CallReason) /js/src/vm/Interpreter.cpp:544:13
        #14 0x7f23bb8a6f9b in js::Call(JSContext*, JS::Handle<JS::Value>, JS::Handle<JS::Value>, js::AnyInvokeArgs const&, JS::MutableHandle<JS::Value>, js::CallReason) /js/src/vm/Interpreter.cpp:589:8
        #15 0x7f23bbe465a7 in js::CallSelfHostedFunction(JSContext*, JS::Handle<js::PropertyName*>, JS::Handle<JS::Value>, js::AnyInvokeArgs const&, JS::MutableHandle<JS::Value>) /js/src/vm/SelfHosting.cpp:1539:10
        #16 0x7f23bbaee329 in AsyncFunctionResume(JSContext*, JS::Handle<js::AsyncFunctionGeneratorObject*>, ResumeKind, JS::Handle<JS::Value>) /js/src/vm/AsyncFunction.cpp:152:8
        #17 0x7f23bbca430a in AsyncFunctionPromiseReactionJob /js/src/builtin/Promise.cpp:1949:12
        #18 0x7f23bbca430a in PromiseReactionJob(JSContext*, unsigned int, JS::Value*) /js/src/builtin/Promise.cpp:2012:12
        #19 0x7f23bb8a4d14 in CallJSNative /js/src/vm/Interpreter.cpp:425:13
        #20 0x7f23bb8a4d14 in js::InternalCallOrConstruct(JSContext*, JS::CallArgs const&, js::MaybeConstruct, js::CallReason) /js/src/vm/Interpreter.cpp:512:12
        #21 0x7f23bb8a6f9b in js::Call(JSContext*, JS::Handle<JS::Value>, JS::Handle<JS::Value>, js::AnyInvokeArgs const&, JS::MutableHandle<JS::Value>, js::CallReason) /js/src/vm/Interpreter.cpp:589:8
        #22 0x7f23bbb251dd in JS::Call(JSContext*, JS::Handle<JS::Value>, JS::Handle<JS::Value>, JS::HandleValueArray const&, JS::MutableHandle<JS::Value>) /js/src/vm/CallAndConstruct.cpp:117:10
        #23 0x7f23b2a5441c in mozilla::dom::PromiseJobCallback::Call(mozilla::dom::BindingCallContext&, JS::Handle<JS::Value>, mozilla::ErrorResult&) /builds/worker/workspace/obj-build/dom/bindings/PromiseBinding.cpp:35:8
        #24 0x7f23ae33fb07 in Call /builds/worker/workspace/obj-build/dist/include/mozilla/dom/PromiseBinding.h:89:12
        #25 0x7f23ae33fb07 in Call /builds/worker/workspace/obj-build/dist/include/mozilla/dom/PromiseBinding.h:102:12
        #26 0x7f23ae33fb07 in mozilla::PromiseJobRunnable::Run(mozilla::AutoSlowOperation&) /xpcom/base/CycleCollectedJSContext.cpp:213:18
        #27 0x7f23ae31e977 in mozilla::CycleCollectedJSContext::PerformMicroTaskCheckPoint(bool) /xpcom/base/CycleCollectedJSContext.cpp:674:17
        #28 0x7f23ae31f95f in mozilla::CycleCollectedJSContext::AfterProcessTask(unsigned int) /xpcom/base/CycleCollectedJSContext.cpp:463:3
        #29 0x7f23b0951e16 in XPCJSContext::AfterProcessTask(unsigned int) /js/xpconnect/src/XPCJSContext.cpp:1478:28
        #30 0x7f23ae563238 in nsThread::ProcessNextEvent(bool, bool*) /xpcom/threads/nsThread.cpp:1232:24
        #31 0x7f23ae56decc in NS_ProcessNextEvent(nsIThread*, bool) /xpcom/threads/nsThreadUtils.cpp:467:10
        #32 0x7f23afa80784 in mozilla::ipc::MessagePump::Run(base::MessagePump::Delegate*) /ipc/glue/MessagePump.cpp:107:5
        #33 0x7f23af9057a1 in RunInternal /ipc/chromium/src/base/message_loop.cc:331:10
        #34 0x7f23af9057a1 in RunHandler /ipc/chromium/src/base/message_loop.cc:324:3
        #35 0x7f23af9057a1 in MessageLoop::Run() /ipc/chromium/src/base/message_loop.cc:306:3
        #36 0x7f23b689d2f7 in nsBaseAppShell::Run() /widget/nsBaseAppShell.cpp:137:27
        #37 0x7f23bb5c255f in XRE_RunAppShell() /toolkit/xre/nsEmbedFunctions.cpp:870:20
        #38 0x7f23af9057a1 in RunInternal /ipc/chromium/src/base/message_loop.cc:331:10
        #39 0x7f23af9057a1 in RunHandler /ipc/chromium/src/base/message_loop.cc:324:3
        #40 0x7f23af9057a1 in MessageLoop::Run() /ipc/chromium/src/base/message_loop.cc:306:3
        #41 0x7f23bb5c1793 in XRE_InitChildProcess(int, char**, XREChildData const*) /toolkit/xre/nsEmbedFunctions.cpp:707:34
        #42 0x5603daeec07d in content_process_main(mozilla::Bootstrap*, int, char**) /browser/app/../../ipc/contentproc/plugin-container.cpp:57:28
        #43 0x5603daeec4a8 in main /browser/app/nsBrowserApp.cpp:327:18
        #44 0x7f23d2d930b2 in __libc_start_main /build/glibc-eX1tMB/glibc-2.31/csu/../csu/libc-start.c:308:16
        #45 0x5603dae3b149 in _start (/home/jkratzer/builds/mc-asan/firefox+0x5d149)
    
    AddressSanitizer can not provide additional info.
    SUMMARY: AddressSanitizer: SEGV /builds/worker/workspace/obj-build/dist/include/nsINode.h:1809:12 in GetBoolFlag
    ==3146062==ABORTING

Comment 1

[Jason Kratzer [:jkratzer]]

Attachment: Testcase

Comment 2

[Mayank Bansal]

https://crash-stats.mozilla.org/report/index/f2ee8c75-6c8c-45f4-b3ab-ba6910220129#tab-bugzilla

Comment 3

[Bugmon [:jkratzer for issues]]

Bugmon Analysis
Verified bug as reproducible on mozilla-central 20220130093554-12ecc19b4b60.
The bug appears to have been introduced in the following build range:

Start: 1f856a88914ab02d164fd47e334b03848dae2049 (20210818155306)
End: cfb323870af4cbe082a6e01d3c20786a61165585 (20210818145907)
Pushlog: https://hg.mozilla.org/mozilla-unified/pushloghtml?fromchange=1f856a88914ab02d164fd47e334b03848dae2049&tochange=cfb323870af4cbe082a6e01d3c20786a61165585

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:kvark, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 5

[Bugmon [:jkratzer for issues]]

Bugmon Analysis
Testcase crashes using the initial build (mozilla-central 20220128155052-48e8fb0b62c5) but not with tip (mozilla-central 20220218215229-b21fa00b5f33.)
The bug appears to have been fixed in the following build range:

Start: 18c11a93ef165c18b95a536fbead227b048bce65 (20220216205433)
End: 2f26fa82e27c30648e9ab0e3b1a4144bc33d9605 (20220216223613)
Pushlog: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=18c11a93ef165c18b95a536fbead227b048bce65&tochange=2f26fa82e27c30648e9ab0e3b1a4144bc33d9605
Removing bugmon keyword as no further action possible. Please review the bug and re-add the keyword for further analysis.

Comment 6

[Takanori MATSUURA]

According to the comment #5, the bug appears to have been fixed.
Does this still reproduce?

Comment 7

[Jason Kratzer [:jkratzer]]

No. This bug appears to have been fixed via bug 1754978.