1752628 - Verify that AC doesn't accidentally unload tabs

Status: RESOLVED FIXED

(GeckoView :: General, task, P2)

Description

[[:owlish] 🦉 PST]

One of the possible reasons for the tab reloading issue is a potential bug in AC that causes undesired tab unloads. We need to make sure that doesn't happen.

In Fenix, trim on memory pressure is disabled on Nightly: https://github.com/mozilla-mobile/fenix/blob/main/app/src/main/java/org/mozilla/fenix/components/Core.kt#L227

You can also look at all references to the LowMemoryAction to verify as well.

Another place to look is to check the SuspendEngineSessionAction - how it's used for tab reloads or closes and when does that happen.

Comment 1

[Christian Sadilek [:csadilek]]

I've verified that A-C and Fenix do not unload tabs / close sessions, unless onCrash and onKill are called on the content delegate. At that point, it doesn't matter. Fenix is no longer closing sessions under memory pressure. I think we can close this.