1752645 - [wpt-sync] Sync PR 32604 - App history: fix DCHECK crash on navigating from about:blank

Status: RESOLVED FIXED

(Testing :: web-platform-tests, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 32604 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/32604
Details from upstream follow.

Domenic Denicola <[e-mail]> wrote:

App history: fix DCHECK crash on navigating from about:blank

This ensures

The test in web_tests/ is confirmed to crash without this fix and pass afterward. The tests in external/wpt/ pass before and after this fix, sadly, but seemed worth including anyway with an appropriate comment.

Fixed: 1289864
Bug: 1289724 (probably also fixed but we will let Clusterfuzz confirm)

Change-Id: I4d6c21f80e716648ca4271ca5b4b2299d398f5e7

Reviewed-on: https://chromium-review.googlesource.com/3425259
WPT-Export-Revision: 7c52b5e41b916b152b438e9899795b02ec8adcbf

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=5b899a30e6985b541d01e397eb0b367aa0d447e5

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 2 tests and 1 subtests

Status Summary

Firefox

OK : 2
FAIL: 2

Chrome

OK : 2
PASS: 2

Safari

OK : 2
FAIL: 2

Links

GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/app-history/navigate/navigate-from-initial-about-blank-src.html
navigate() from <iframe> with src="" but still on initial about:blank works: FAIL (Chrome: PASS, Safari: FAIL)
/app-history/navigate/navigate-from-initial-about-blank.html
navigate() from <iframe> still on initial about:blank works: FAIL (Chrome: PASS, Safari: FAIL)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d21e8acc6fcc
[wpt PR 32604] - App history: fix DCHECK crash on navigating from about:blank, a=testonly
https://hg.mozilla.org/integration/autoland/rev/7bcf9588d0a2
[wpt PR 32604] - Update wpt metadata, a=testonly

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a2f661abef05
[wpt PR 32604] - App history: fix DCHECK crash on navigating from about:blank, a=testonly
https://hg.mozilla.org/integration/autoland/rev/6b6ddd91dd74
[wpt PR 32604] - Update wpt metadata, a=testonly

Comment 5

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/a2f661abef05
https://hg.mozilla.org/mozilla-central/rev/6b6ddd91dd74