1752718 - Attachment context menu command "Import OpenPGP key" fails

Status: RESOLVED FIXED

(MailNews Core :: Security: OpenPGP, defect)

Description

[Kai Engert (:KaiE:)]

From Nico:

If I try to import my own key attached by TB 91.5 with right-click "Import OpenPGP Key" I get an error message "Can't read public key". But I can import it fine from the key manager if saved in my home.

Comment 1

[Kai Engert (:KaiE:)]

Attachment: Bug 1752718 - Ensure callers of KeyObj.getKeyListFromKeyBlock see a valid errorMsgObj.value. r=mkmelin

Comment 2

[Arvidt]

Might this bug be related to bug 1748722 ? In enigdbug.txt attached to that bug (see https://bugzilla.mozilla.org/show_bug.cgi?id=1748722#c4) the last line is [DEBUG] key.jsm: getKeyListFromKeyBlock

Comment 3

[Magnus Melin [:mkmelin]]

Was this regressed by bug 1742578?

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/e13fe0c98be4
Ensure callers of KeyObj.getKeyListFromKeyBlock see a valid errorMsgObj.value. r=mkmelin

Comment 5

[Kai Engert (:KaiE:)]

Comment on attachment 9261426 [details]
Bug 1752718 - Ensure callers of KeyObj.getKeyListFromKeyBlock see a valid errorMsgObj.value. r=mkmelin

[Approval Request Comment]
Regression caused by (bug #):
User impact if declined: functionality not working
Testing completed (on c-c, etc.):
Risk to taking this patch (and alternatives if risky): zero risk, just a variable init

Comment 6

[Wayne Mery (:wsmwk)]

Comment on attachment 9261426 [details]
Bug 1752718 - Ensure callers of KeyObj.getKeyListFromKeyBlock see a valid errorMsgObj.value. r=mkmelin

[Triage Comment]
I'm OK taking this based on solid assessment of "zero risk". And it looks like it should be.
Approved for esr91.

Comment 7

[Rob Lemley [:rjl]]

Thunderbird 91.6.0:
https://hg.mozilla.org/releases/comm-esr91/rev/2a325fe49a3e