1752790 - [wpt-sync] Sync PR 32615 - Abort Element::SetNeedsAnimationStyleRecalc during EnsureComputedStyle

Status: RESOLVED FIXED

(Core :: DOM: Animation, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 32615 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/32615
Details from upstream follow.

Anders Hartvoll Ruud <[e-mail]> wrote:

Abort Element::SetNeedsAnimationStyleRecalc during EnsureComputedStyle

The animations machinery currently calls Element::
SetNeedsAnimationStyleRecalc during style resolution, but we early-out
from that function if Document::InStyleRecalc is true. This does
however not cover Element::EnsureComputedStyle, which means that
calling that function can actually mark elements for style recalc.

To address this, let InStyleRecalc be 'true' during
EnsureComputedStyle.

Fixed: 1290016
Change-Id: Ic25f2f7f22f3d3960d4ee0726c16d9a7a91f24b9
Reviewed-on: https://chromium-review.googlesource.com/3423875
WPT-Export-Revision: f39f1630ef95a92b50999b254340a56aca2c1118

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=7d7ebd008a0048698c76ec49505981f37080a2dc

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests

Status Summary

Firefox

PASS: 1

Chrome

PASS: 1

Safari

PASS: 1

Links

GitHub PR Head
GitHub PR Base

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/44582d23ee76
[wpt PR 32615] - Abort Element::SetNeedsAnimationStyleRecalc during EnsureComputedStyle, a=testonly

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9de07219d106
[wpt PR 32615] - Abort Element::SetNeedsAnimationStyleRecalc during EnsureComputedStyle, a=testonly

Comment 5

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/9de07219d106