Open Bug 1752860 Opened 3 years ago Updated 3 years ago

Window-specific themes should not change global color scheme

Categories

(Firefox :: Theme, enhancement)

Product:
Firefox
Component:
Theme
Type:
enhancement

Tracking

()

People

(Reporter: robwu, Unassigned)

References

Details

The browser.theme.update extension API allows extensions to dynamically change the colors of a specific window.

The implementation of color scheme selection does not account for that. It unconditionally updates the (content) color scheme when a theme is updated.

At the least, updateGlobalThemeData should be set to false if data.window is set (it originates from https://searchfox.org/mozilla-central/rev/78963fe42f8d5f582f84da84a5e78377b6c1fc32/toolkit/components/extensions/parent/ext-theme.js#124-126,135-138).

To address failing heuristics in bug 1749837, the color_scheme and content_color_scheme properties are being introduced in bug 1750932. While content_color_scheme cannot be supported, the color_scheme property should be effective at selecting the right color scheme for the window.

You need to log in before you can comment on or make changes to this bug.